Changeset 8612

Timestamp:

07/15/2014 07:14:28 PM (11 years ago)

Author:

djpaul

Message:

Core: make the filter in bp_core_register_common_scripts() more useful.

Prior to this change, the data passed to the filter was pretty limited, making the filter
not very useful. This change makes the filter provide a full path for the scripts being
registered and allows scripts' dependencies to be set.

Minor codestyle improvements have also been included.

File:

• trunk/src/bp-core/bp-core-cssjs.php (modified) (1 diff)

trunk/src/bp-core/bp-core-cssjs.php

@@ -11 +11 @@
 
 /**
- * Register scripts commonly used by BuddyPress plugins and themes.
+ * Register scripts commonly used by BuddyPress.
  *
  * @since BuddyPress (2.1.0)
  */
 function bp_core_register_common_scripts() {
-
-    // Whether or not to use minified versions
-    $min  = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';
-
-    // Get the version for busting caches
-    $ver  = bp_get_version();
-
-    // Get the common core JS URL
-    $url  = buddypress()->plugin_url . 'bp-core/js/';
+    $ext = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';
+    $url = buddypress()->plugin_url . 'bp-core/js/';
     
-    // Array of common scripts
     $scripts = apply_filters( 'bp_core_register_common_scripts', array(
-        'bp-confirm'          => 'confirm',
-        'bp-widget-members'   => 'widget-members',
-        'bp-jquery-query'     => 'jquery-query',
-        'bp-jquery-cookie'    => 'jquery-cookie',
+        'bp-confirm'        => array( 'file' => "{$url}confirm{$ext}",        'dependencies' => array( 'jquery' ) ),
+        'bp-widget-members' => array( 'file' => "{$url}widget-members{$ext}", 'dependencies' => array( 'jquery' ) ),
+        'bp-jquery-query'   => array( 'file' => "{$url}jquery-query{$ext}",   'dependencies' => array( 'jquery' ) ),
+        'bp-jquery-cookie'  => array( 'file' => "{$url}jquery-cookie{$ext}",  'dependencies' => array( 'jquery' ) ),
     ) );
 
-    // Register scripts commonly used by BuddyPress themes
-    foreach ( $scripts as $id => $file ) {
-        wp_register_script( $id, $url . $file . $min, array( 'jquery' ), $ver );
+    foreach ( $scripts as $id => $script ) {
+        wp_register_script( $id, $script['file'], $script['dependencies'], bp_get_version() );
     }
 }