Changeset 8605 for trunk/src/bp-templates/bp-legacy/buddypress/groups/single/home.php

Timestamp:

07/12/2014 01:26:36 AM (12 years ago)

Author:

boonebgorges

Message:

Overhaul access and visibility control for group tabs

Previously, access control to group tabs was handled in two ways:

• for BP_Group_Extension tabs, the 'enable_nav_item' and 'visibility' provided some control over access to plugin developers, though it was inconsistent, buggy, and difficult to implement properly
• for tabs provided by bp-groups, access to the tabs of non-public groups was controlled directly in the BP_Groups_Component::setup_globals() method

Aside from being unclear for developers, this technique for controlling access
was also inflexible. For non-public groups, tab access was hardcoded and
handled before BP_Group_Extension plugins even had a chance to load. As a
result, it was essentially impossible to add public tabs to non-public groups
(among other non-standard customizations).

The current changeset comprises a number of changes that make tab access more
consistent and flexible:

• Access control is moved to the new bp_groups_group_access_protection() function. This function has the necessary filters to customize access protection in arbitrary ways. And because it loads at 'bp_actions' - just before the page begins to render - all extensions have had a chance to load and register themselves with the desired access settings.
• The 'visibility' and 'enable_nav_item' properties of BP_Group_Extension are phased out in favor of 'access' and 'show_tab' params. 'access' controls who can visit the tab, while 'show_tab' controls who can see the item in the navigation. These new properties have intelligent defaults (based on the privacy level of the group), but can be overridden with a number of custom settings: 'admin', 'mod', 'member', 'loggedin', 'anyone', or 'noone'. Backward compatibility is maintained, so that existing BP_Group_Extension plugins that use enable_nav_item or visibility will continue to work as before.

Fixes #4785

Props boonebgorges, dcavins, imath

File:

• trunk/src/bp-templates/bp-legacy/buddypress/groups/single/home.php (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/buddypress/groups/single/home.php

@@ -34 +34 @@
                  */
 
-                // Group is visible
-                if ( bp_group_is_visible() ) : 
-
                         // Looking at home location
                         if ( bp_is_group_home() ) :
 
-                                // Use custom front if one exists
-                                $custom_front = bp_locate_template( array( 'groups/single/front.php' ), false, true );
-                                if     ( ! empty( $custom_front   ) ) : load_template( $custom_front, true );
+                                if ( bp_group_is_visible() ) {
 
-                                // Default to activity
-                                elseif ( bp_is_active( 'activity' ) ) : bp_get_template_part( 'groups/single/activity' );
+                                        // Use custom front if one exists
+                                        $custom_front = bp_locate_template( array( 'groups/single/front.php' ), false, true );
+                                        if     ( ! empty( $custom_front   ) ) : load_template( $custom_front, true );
 
-                                // Otherwise show members
-                                elseif ( bp_is_active( 'members'  ) ) : bp_groups_members_template_part();
+                                        // Default to activity
+                                        elseif ( bp_is_active( 'activity' ) ) : bp_get_template_part( 'groups/single/activity' );
 
-                                endif;
-                                
+                                        // Otherwise show members
+                                        elseif ( bp_is_active( 'members'  ) ) : bp_groups_members_template_part();
+
+                                        endif;
+
+                                } else {
+
+                                        do_action( 'bp_before_group_status_message' ); ?>
+
+                                        <div id="message" class="info">
+                                                <p><?php bp_group_status_message(); ?></p>
+                                        </div>
+
+                                        <?php do_action( 'bp_after_group_status_message' );
+
+                                }
+
                         // Not looking at home
                         else :
@@ -77 +88 @@
 
                                 endif;
-                        endif;
-
-                // Group is not visible
-                elseif ( ! bp_group_is_visible() ) :
-
-                        // Membership request
-                        if ( bp_is_group_membership_request() ) :
-                                bp_get_template_part( 'groups/single/request-membership' );
-
-                        // The group is not visible, show the status message
-                        else :
-
-                                do_action( 'bp_before_group_status_message' ); ?>
-
-                                <div id="message" class="info">
-                                        <p><?php bp_group_status_message(); ?></p>
-                                </div>
-
-                                <?php do_action( 'bp_after_group_status_message' );
 
                         endif;
-                endif;
 
                 do_action( 'bp_after_group_body' ); ?>