Changeset 8518

Timestamp:

06/15/2014 12:51:03 PM (10 years ago)

Author:

boonebgorges

Message:

Add 'option' to the whitelist of xprofile field types

The 'option' field type is not full-fledged, in the sense that it has an
associated BP_XProfile_Field_Type class; it is used only to save the values
that are child options of type 'radio', 'select', 'multiselect' and other
option-supporting field types. It is important that 'option' thus be added
manually to the field type whitelist, so that option fields can be created
programatically.

Fixes #5472

Location:

trunk

Files:

• src/bp-xprofile/bp-xprofile-loader.php (modified) (1 diff)
• tests/phpunit/testcases/xprofile/functions.php (modified) (1 diff)

trunk/src/bp-xprofile/bp-xprofile-loader.php

@@ -103 +103 @@
         $this->field_types = apply_filters( 'xprofile_field_types', array_keys( bp_xprofile_get_field_types() ) );
 
+        // 'option' is a special case. It is not a top-level field, so
+        // does not have an associated BP_XProfile_Field_Type class,
+        // but it must be whitelisted
+        $this->field_types[] = 'option';
+
         // Register the visibility levels. See bp_xprofile_get_visibility_levels() to filter
         $this->visibility_levels = array(

trunk/tests/phpunit/testcases/xprofile/functions.php

@@ -569 +569 @@
         $this->assertEquals( 0, xprofile_get_field_data( 'Pens', $u ) );
     }
+
+    /**
+     * @group xprofile_insert_field
+     */
+    public function test_xprofile_insert_field_type_option() {
+        $g = $this->factory->xprofile_group->create();
+        $parent = $this->factory->xprofile_field->create( array(
+            'field_group_id' => $g,
+            'type' => 'selectbox',
+            'name' => 'Parent',
+        ) );
+
+        $f = xprofile_insert_field( array(
+            'field_group_id' => $g,
+            'parent_id' => $parent,
+            'type' => 'option',
+            'name' => 'Option 1',
+            'field_order' => 5,
+        ) );
+
+        $this->assertNotEmpty( $f );
+    }
 }