Changeset 8494

Timestamp:

06/10/2014 12:51:44 PM (11 years ago)

Author:

boonebgorges

Message:

Generate list of xprofile field types that support options for Field Admin, rather than hardcoding

This change allows custom field types to support options, while using the core
admin panel UI.

Fixes #5691

Location:

trunk/src/bp-xprofile

Files:

• admin/js/admin.js (modified) (1 diff)
• bp-xprofile-cssjs.php (modified) (1 diff)

trunk/src/bp-xprofile/admin/js/admin.js

@@ -62 +62 @@
 }
 
-function show_options(forWhat) {
-    document.getElementById( 'radio'          ).style.display = 'none';
-    document.getElementById( 'selectbox'      ).style.display = 'none';
-    document.getElementById( 'multiselectbox' ).style.display = 'none';
-    document.getElementById( 'checkbox'       ).style.display = 'none';
-
-    if ( forWhat === 'radio' ) {
-        document.getElementById( 'radio' ).style.display = '';
-    }
-
-    if ( forWhat === 'selectbox' ) {
-        document.getElementById( 'selectbox' ).style.display = '';
-    }
-
-    if ( forWhat === 'multiselectbox' ) {
-        document.getElementById( 'multiselectbox' ).style.display = '';
-    }
-
-    if ( forWhat === 'checkbox' ) {
-        document.getElementById( 'checkbox' ).style.display = '';
+/**
+ * Hide all "options" sections, and show the options section for the forWhat type.
+ */
+function show_options( forWhat ) {
+    for ( var i = 0; i < XProfileAdmin.supports_options_field_types.length; i++ ) {
+        document.getElementById( XProfileAdmin.supports_options_field_types[i] ).style.display = 'none';
+    }
+
+    if ( XProfileAdmin.supports_options_field_types.indexOf( forWhat ) >= 0 ) {
+        document.getElementById( forWhat ).style.display = '';
     }
 }

trunk/src/bp-xprofile/bp-xprofile-cssjs.php

@@ -40 +40 @@
         $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
         wp_enqueue_script( 'xprofile-admin-js', buddypress()->plugin_url . "bp-xprofile/admin/js/admin{$min}.js", array( 'jquery', 'jquery-ui-sortable' ), bp_get_version() );
+
+        // Localize strings.
+        // supports_options_field_types is a dynamic list of field
+        // types that support options, for use in showing/hiding the
+        // "please enter options for this field" section
+        $strings = array(
+            'supports_options_field_types' => array(),
+        );
+
+        foreach ( bp_xprofile_get_field_types() as $field_type => $field_type_class ) {
+            $field = new $field_type_class();
+            if ( $field->supports_options ) {
+                $strings['supports_options_field_types'][] = $field_type;
+            }
+        }
+
+        wp_localize_script( 'xprofile-admin-js', 'XProfileAdmin', $strings );
     }
 }