Changeset 8453 for trunk/src/bp-core/bp-core-cssjs.php

Timestamp:

05/27/2014 05:10:54 AM (8 years ago)

Author:

johnjamesjacoby

Message:

First pass at unbundling inline jQuery plugins from BP Legacy's buddypress.js and BP Default's global.js. See #5208.

File:

• trunk/src/bp-core/bp-core-cssjs.php (modified) (5 diffs)

trunk/src/bp-core/bp-core-cssjs.php

@@ -9 +9 @@
 // Exit if accessed directly
 if ( !defined( 'ABSPATH' ) ) exit;
+
+/**
+ * Register scripts commonly used by BuddyPress plugins and themes.
+ *
+ * @since BuddyPress (2.1.0)
+ */
+function bp_core_register_common_scripts() {
+
+    // Whether or not to use minified versions
+    $min  = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';
+
+    // Get the version for busting caches
+    $ver  = bp_get_version();
+
+    // Get the common core JS URL
+    $url  = buddypress()->plugin_url . 'bp-core/js/';
+    
+    // Array of common scripts
+    $scripts = apply_filters( 'bp_core_register_common_scripts', array(
+        'bp-confirm'          => 'confirm',
+        'bp-widget-members'   => 'widget-members',
+        'bp-jquery-query'     => 'jquery-query',
+        'bp-jquery-cookie'    => 'jquery-cookie',
+        'bp-jquery-scroll-to' => 'jquery-scroll-to',
+    ) );
+
+    // Register scripts commonly used by BuddyPress themes
+    foreach ( $scripts as $id => $file ) {
+        wp_register_script( $id, $url . $file . $min, array( 'jquery' ), $ver );
+    }
+}
+add_action( 'bp_enqueue_scripts', 'bp_core_register_common_scripts', 1 );
 
 /**
@@ -18 +50 @@
     }
 
-    $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
-    wp_enqueue_script( 'bp-confirm', buddypress()->plugin_url . "bp-core/js/confirm{$min}.js", array( 'jquery' ), bp_get_version() );
+    wp_enqueue_script( 'bp-confirm' );
 
     wp_localize_script( 'bp-confirm', 'BP_Confirm', array(
@@ -26 +57 @@
 
 }
-add_action( 'wp_enqueue_scripts',    'bp_core_confirmation_js' );
+add_action( 'bp_enqueue_scripts',    'bp_core_confirmation_js' );
 add_action( 'admin_enqueue_scripts', 'bp_core_confirmation_js' );
 
@@ -70 +101 @@
             jQuery('#avatar-to-crop').Jcrop({
                 onChange: showPreview,
-                onSelect: showPreview,
                 onSelect: updateCoords,
                 aspectRatio: <?php echo $aspect_ratio; ?>,
@@ -154 +184 @@
     return apply_filters( 'bp_core_ajax_url', admin_url( 'admin-ajax.php', is_ssl() ? 'admin' : 'http' ) );
 }
+
+/**
+ * Get the javascript dependencies for buddypress.js.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @uses apply_filters() to allow other component to load extra dependencies
+ *
+ * @return array The javascript dependencies.
+ */
+function bp_core_get_js_dependencies() {
+    return apply_filters( 'bp_core_get_js_dependencies', array(
+        'jquery',
+        'bp-confirm',
+        'bp-widget-members',
+        'bp-jquery-query',
+        'bp-jquery-cookie',
+        'bp-jquery-scroll-to'
+    ) );
+}