Changeset 8428 for trunk/src/bp-xprofile/bp-xprofile-activity.php

Timestamp:

05/16/2014 01:05:35 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce bp_activity_show_filters(), and use it for generating dynamic activity filter dropdowns

Activity filter dropdowns were previously hardcoded into templates, with
template-specific hooks for plugins to add their own filter values. This
resulted in an inconsistent and awkward process of maintaining filter lists
between components. The new method introduces new parameters to bp_activity_set_action():
$context (an array of the contexts in which the filter should appear) and
$label (the text that should be used when generating the <option> markup). The
new function bp_activity_show_filter() is then used in the templates to
generate a dynamic list of <option> markup, based on the values registered by
the activity types.

Fixes #5637

Props imath

File:

• trunk/src/bp-xprofile/bp-xprofile-activity.php (modified) (5 diffs)

trunk/src/bp-xprofile/bp-xprofile-activity.php

@@ -22 +22 @@
         // see r4273
         'profile',
-
         'new_avatar',
         __( 'Member changed profile picture', 'buddypress' ),
-        'bp_xprofile_format_activity_action_new_avatar'
+        'bp_xprofile_format_activity_action_new_avatar',
+        __( 'Updated Avatars', 'buddypress' )
     );
 
@@ -32 +32 @@
         'new_member',
         __( 'New member registered', 'buddypress' ),
-        'bp_xprofile_format_activity_action_new_member'
+        'bp_xprofile_format_activity_action_new_member',
+        __( 'New Members', 'buddypress' ),
+        array( 'activity' )
     );
 
@@ -39 +41 @@
         'updated_profile',
         __( 'Updated Profile', 'buddypress' ),
-        'bp_xprofile_format_activity_action_updated_profile'
+        'bp_xprofile_format_activity_action_updated_profile',
+        __( 'Profile Updates', 'buddypress' ),
+        array( 'activity' )
     );
 
@@ -310 +314 @@
  *
  * @since BuddyPress (2.0.0)
+ * @todo Mark as deprecated
  */
 function xprofile_activity_filter_options() {
@@ -318 +323 @@
     <?php
 }
-add_action( 'bp_activity_filter_options', 'xprofile_activity_filter_options' );