Changeset 8428 for trunk/src/bp-groups/bp-groups-activity.php

Timestamp:

05/16/2014 01:05:35 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce bp_activity_show_filters(), and use it for generating dynamic activity filter dropdowns

Activity filter dropdowns were previously hardcoded into templates, with
template-specific hooks for plugins to add their own filter values. This
resulted in an inconsistent and awkward process of maintaining filter lists
between components. The new method introduces new parameters to bp_activity_set_action():
$context (an array of the contexts in which the filter should appear) and
$label (the text that should be used when generating the <option> markup). The
new function bp_activity_show_filter() is then used in the templates to
generate a dynamic list of <option> markup, based on the values registered by
the activity types.

Fixes #5637

Props imath

File:

• trunk/src/bp-groups/bp-groups-activity.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-activity.php

@@ -28 +28 @@
         'created_group',
         __( 'Created a group', 'buddypress' ),
-        'bp_groups_format_activity_action_created_group'
+        'bp_groups_format_activity_action_created_group',
+        __( 'New Groups', 'buddypress' ),
+        array( 'activity', 'member', 'member_groups' )
     );
 
@@ -35 +37 @@
         'joined_group',
         __( 'Joined a group', 'buddypress' ),
-        'bp_groups_format_activity_action_joined_group'
+        'bp_groups_format_activity_action_joined_group',
+        __( 'Group Memberships', 'buddypress' ),
+        array( 'activity', 'group', 'member', 'member_groups' )
     );
 
@@ -42 +46 @@
     // check for the legacy forums loader class to be extra cautious
     if ( bp_is_active( 'forums' ) && class_exists( 'BP_Forums_Component' ) ) {
-        bp_activity_set_action( $bp->groups->id, 'new_forum_topic', __( 'New group forum topic', 'buddypress' ) );
-        bp_activity_set_action( $bp->groups->id, 'new_forum_post',  __( 'New group forum post',  'buddypress' ) );
+        bp_activity_set_action(
+            $bp->groups->id,
+            'new_forum_topic',
+            __( 'New group forum topic', 'buddypress' ),
+            false,
+            __( 'Forum Topics', 'buddypress' ),
+            array( 'activity', 'group', 'member', 'member_groups' )
+        );
+
+        bp_activity_set_action(
+            $bp->groups->id,
+            'new_forum_post',
+            __( 'New group forum post',  'buddypress' ),
+            false,
+            __( 'Forum Replies', 'buddypress' ),
+            array( 'activity', 'group', 'member', 'member_groups' )
+        );
     }