Changeset 8428 for trunk/src/bp-activity/bp-activity-functions.php

Timestamp:

05/16/2014 01:05:35 PM (12 years ago)

Author:

boonebgorges

Message:

Introduce bp_activity_show_filters(), and use it for generating dynamic activity filter dropdowns

Activity filter dropdowns were previously hardcoded into templates, with
template-specific hooks for plugins to add their own filter values. This
resulted in an inconsistent and awkward process of maintaining filter lists
between components. The new method introduces new parameters to bp_activity_set_action():
$context (an array of the contexts in which the filter should appear) and
$label (the text that should be used when generating the <option> markup). The
new function bp_activity_show_filter() is then used in the templates to
generate a dynamic list of <option> markup, based on the values registered by
the activity types.

Fixes #5637

Props imath

File:

• trunk/src/bp-activity/bp-activity-functions.php (modified) (4 diffs)

trunk/src/bp-activity/bp-activity-functions.php

@@ -276 +276 @@
  * @param string $description The action description.
  * @param callable $format_callback Callback for formatting the action string.
+ * @param string $label String to describe this action in the activity stream
+ *        filter dropdown.
+ * @param array $context Activity stream contexts where the filter should appear.
+ *        'activity', 'member', 'member_groups', 'group'
  * @return bool False if any param is empty, otherwise true.
  */
-function bp_activity_set_action( $component_id, $type, $description, $format_callback = false ) {
+function bp_activity_set_action( $component_id, $type, $description, $format_callback = false, $label = false, $context = array() ) {
     $bp = buddypress();
 
@@ -304 +308 @@
         'value'           => $description,
         'format_callback' => $format_callback,
-    ), $component_id, $type, $description, $format_callback );
+        'label'           => $label,
+        'context'         => $context,
+    ), $component_id, $type, $description, $format_callback, $label, $context );
 
     return true;
@@ -836 +842 @@
         'activity_update',
         __( 'Posted a status update', 'buddypress' ),
-        'bp_activity_format_activity_action_activity_update'
+        'bp_activity_format_activity_action_activity_update',
+        __( 'Updates', 'buddypress' ),
+        array( 'activity', 'group', 'member', 'member_groups' )
     );
 
@@ -843 +851 @@
         'activity_comment',
         __( 'Replied to a status update', 'buddypress' ),
-        'bp_activity_format_activity_action_activity_comment'
+        'bp_activity_format_activity_action_activity_comment',
+        __( 'Activity Comments', 'buddypress' )
     );