Changeset 8333 for trunk/bp-members/bp-members-functions.php

Timestamp:

04/30/2014 07:22:59 PM (11 years ago)

Author:

boonebgorges

Message:

When migrating last_activity data, clear all data to avoid duplicates

Previously, duplicates were avoided with a NOT IN subquery. But this caused
load problems on large installations, where the subquery would return
many thousands of results.

Fixes #5572

File:

• trunk/bp-members/bp-members-functions.php (modified) (2 diffs)

trunk/bp-members/bp-members-functions.php

@@ -1037 +1037 @@
     $bp = buddypress();
 
-    // The "NOT IN" clause prevents duplicates
+    // Wipe out existing last_activity data in the activity table -
+    // this helps to prevent duplicates when pulling from the usermeta
+    // table
+    $wpdb->query( $wpdb->prepare( "DELETE FROM {$bp->members->table_name_last_activity} WHERE component = %s AND type = 'last_activity'", $bp->members->id ) );
+
     $sql = "INSERT INTO {$bp->members->table_name_last_activity} (`user_id`, `component`, `type`, `action`, `content`, `primary_link`, `item_id`, `date_recorded` ) (
           SELECT user_id, '{$bp->members->id}' as component, 'last_activity' as type, '' as action, '' as content, '' as primary_link, 0 as item_id, meta_value AS date_recorded
@@ -1043 +1047 @@
           WHERE
             meta_key = 'last_activity'
-            AND
-            user_id NOT IN (
-              SELECT user_id
-              FROM {$bp->members->table_name_last_activity}
-              WHERE component = '{$bp->members->id}' AND type = 'last_activity'
-            )
     );";