Changeset 8320

Timestamp:

04/24/2014 09:59:17 PM (12 years ago)

Author:

boonebgorges

Message:

Update bp_last_activity cache when fetching user last_activity.

The cache doesn't do much when it's not set :)

Location:

trunk

Files:

• bp-core/bp-core-classes.php (modified) (2 diffs)
• tests/testcases/core/class-bp-core-user.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -1333 +1333 @@
 
                 // get cache for single user only
+                // @todo Why only single user?
                 if ( ! is_array( $user_id ) ) {
                         $cache = wp_cache_get( $user_id, 'bp_last_activity' );
@@ -1356 +1357 @@
                                 'activity_id'   => $last_activity->id,
                         );
+                }
+
+                // If this was a single user query, update the cache
+                if ( ! is_array( $user_id ) && isset( $retval[ $user_id ] ) ) {
+                        wp_cache_set( $user_id, $retval[ $user_id ], 'bp_last_activity' );
                 }
 

trunk/tests/testcases/core/class-bp-core-user.php

@@ -160 +160 @@
          * @group last_activity
          */
+        public function test_get_last_activity_store_in_cache() {
+                $u = $this->create_user();
+                $time = bp_core_current_time();
+
+                // Cache is set during user creation. Clear to reflect actual
+                // pageload
+                wp_cache_delete( $u, 'bp_last_activity' );
+
+                // prime cache
+                $a = BP_Core_User::get_last_activity( $u );
+
+                $this->assertNotEmpty( wp_cache_get( $u, 'bp_last_activity' ) );
+        }
+
+        /**
+         * @group last_activity
+         */
         public function test_update_last_activity() {
                 $u = $this->create_user();