Changeset 8316

Timestamp:

04/24/2014 01:04:43 AM (12 years ago)

Author:

boonebgorges

Message:

Ensure that existing 'description' is not wiped out when running groups_create_group() with an existing group

Fixes #5576

Location:

trunk

Files:

• bp-groups/bp-groups-functions.php (modified) (1 diff)
• tests/testcases/groups/functions.php (modified) (1 diff)

trunk/bp-groups/bp-groups-functions.php

@@ -102 +102 @@
                 $name  = ! empty( $name ) ? $name : $group->name;
                 $slug  = ! empty( $slug ) ? $slug : $group->slug;
+                $description = ! empty( $description ) ? $description : $group->description;
 
                 // Groups need at least a name

trunk/tests/testcases/groups/functions.php

@@ -272 +272 @@
 
         /**
+         * @group groups_create_group
+         */
+        public function test_groups_create_group_dont_delete_description_for_existing_group_when_no_description_is_passed() {
+                $g = $this->factory->group->create();
+
+                $group_before = groups_get_group( array(
+                        'group_id' => $g,
+                ) );
+
+                groups_create_group( array(
+                        'group_id' => $g,
+                        'enable_forum' => 1,
+                ) );
+
+                $group_after = groups_get_group( array(
+                        'group_id' => $g,
+                ) );
+
+                $this->assertSame( $group_before->description, $group_after->description );
+        }
+
+        /**
          * @group groupmeta
          * @ticket BP5180