Changeset 8315 for trunk/tests/testcases/members/functions.php

Timestamp:

04/24/2014 12:22:29 AM (12 years ago)

Author:

boonebgorges

Message:

Improve the migration tool that converts old non-multisite signups to post-2.0 system

This refactoring involves a number of improvements:

• Old signups are identified as those users with user_status=2, instead of those users with an 'activation_key' usermeta value. Use of the latter technique caused problems with upgrades when plugins had interfered in the normal BuddyPress registration flow in such a way as to retain the activation key on activated accounts. user_status=2 is a more reliable technique.
• Querying by user_status=2 means that the get_users() query does not have to include all usermeta, which makes for a more performant query on large sites.
• The migration routine has been broken out into a separate function bp_members_migrate_signups(), and unit tests have been written for it.
• Activation keys are now regenerated for migrated users who did not have an existing key in usermeta for some reason.

Fixes #5553

Props imath

File:

• trunk/tests/testcases/members/functions.php (modified) (1 diff)

trunk/tests/testcases/members/functions.php

@@ -280 +280 @@
                 $this->assertSame( $expected, bp_core_get_user_displaynames( array( $u1, $u2, ) ) );
         }
+
+        /**
+         * @group bp_members_migrate_signups
+         */
+        public function test_bp_members_migrate_signups_standard() {
+                $u = $this->create_user();
+                $u_obj = new WP_User( $u );
+
+                // Fake an old-style registration
+                $key = wp_hash( $u_obj->ID );
+                update_user_meta( $u, 'activation_key', $key );
+
+                global $wpdb;
+                $wpdb->update(
+                        $wpdb->users,
+                        array( 'user_status' => '2', ),
+                        array( 'ID' => $u, ),
+                        array( '%d', ),
+                        array( '%d', )
+                );
+                clean_user_cache( $u );
+
+                bp_members_migrate_signups();
+
+                $found = BP_Signup::get();
+
+                // Use email address as a sanity check
+                $found_email = isset( $found['signups'][0]->user_email ) ? $found['signups'][0]->user_email : '';
+                $this->assertSame( $u_obj->user_email, $found_email );
+
+                // Check that activation keys match
+                $found_key = isset( $found['signups'][0]->activation_key ) ? $found['signups'][0]->activation_key : '';
+                $this->assertSame( $key, $found_key );
+        }
+
+        /**
+         * @group bp_members_migrate_signups
+         */
+        public function test_bp_members_migrate_signups_activation_key_but_user_status_0() {
+                $u = $this->create_user();
+                $u_obj = new WP_User( $u );
+
+                // Fake an old-style registration
+                $key = wp_hash( $u_obj->ID );
+                update_user_meta( $u, 'activation_key', $key );
+
+                // ...but ensure that user_status is 0. This mimics the
+                // behavior of certain plugins that disrupt the BP registration
+                // flow
+                global $wpdb;
+                $wpdb->update(
+                        $wpdb->users,
+                        array( 'user_status' => '0', ),
+                        array( 'ID' => $u, ),
+                        array( '%d', ),
+                        array( '%d', )
+                );
+                clean_user_cache( $u );
+
+                bp_members_migrate_signups();
+
+                // No migrations should have taken place
+                $found = BP_Signup::get();
+                $this->assertEmpty( $found['total'] );
+        }
+
+        /**
+         * @group bp_members_migrate_signups
+         */
+        public function test_bp_members_migrate_signups_no_activation_key_but_user_status_2() {
+                $u = $this->create_user();
+                $u_obj = new WP_User( $u );
+
+                // Fake an old-style registration but without an activation key
+                global $wpdb;
+                $wpdb->update(
+                        $wpdb->users,
+                        array( 'user_status' => '2', ),
+                        array( 'ID' => $u, ),
+                        array( '%d', ),
+                        array( '%d', )
+                );
+                clean_user_cache( $u );
+
+                bp_members_migrate_signups();
+
+                // Use email address as a sanity check
+                $found = BP_Signup::get();
+                $found_email = isset( $found['signups'][0]->user_email ) ? $found['signups'][0]->user_email : '';
+                $this->assertSame( $u_obj->user_email, $found_email );
+        }
 }