Changeset 8251 for trunk/bp-activity/bp-activity-classes.php

Timestamp:

04/08/2014 06:55:30 AM (11 years ago)

Author:

imath

Message:

Insert a new "since" filter for the activity stream to be used by HeartBeat check feature

In rare cases, the field date_recorded of the activity table can be updated to a date greater than the most recent activity in terms of id.
The Heartbeat feature was based on the id field so far, while the activity stream is sorting items according to the date_recorded field. As a result, in this very particular case, activities with an id greater than the activity (which date has been updated) will be loaded again in the stream and this until a new activity is published.
To prevent this to happen, we introduce this new "since" filter to be used by the HeartBeat feature once it gets the timestamp of the most recent activity displayed in the stream.

props SGr33n, boonebgorges, imath

Fixes #5505

File:

• trunk/bp-activity/bp-activity-classes.php (modified) (3 diffs)

trunk/bp-activity/bp-activity-classes.php

@@ -1190 +1190 @@
      *
      * @param array $filter_array {
-     *     Fields and values to filter by. Each can be either a single
-     *     string, a comma-separated list, or an array of values.
+     *     Fields and values to filter by.
      *     @type array|string|id $user_id User ID(s).
      *     @type array|string $object Corresponds to the 'component'
@@ -1201 +1200 @@
      *     @type array|string|int $secondary_id Corresponds to the
      *           'secondary_item_id' column in the database.
+     *     @type int $offset Return only those items with an ID greater
+     *           than the offset value.
+     *     @type string $since Return only those items that have a
+     *           date_recorded value greater than a given MySQL-formatted
+     *           date.
      * }
      * @return string The filter clause, for use in a SQL query.
@@ -1241 +1245 @@
             $sid_sql = absint( $filter_array['offset'] );
             $filter_sql[] = "a.id >= {$sid_sql}";
+        }
+
+        if ( ! empty( $filter_array['since'] ) ) {
+            // Validate that this is a proper Y-m-d H:i:s date
+            // Trick: parse to UNIX date then translate back
+            $translated_date = date( 'Y-m-d H:i:s', strtotime( $filter_array['since'] ) );
+            if ( $translated_date === $filter_array['since'] ) {
+                $filter_sql[] = "a.date_recorded > '{$translated_date}'";
+            }
         }