Changeset 8232 for trunk/bp-xprofile/bp-xprofile-admin.php

Timestamp:

04/04/2014 11:18:22 AM (11 years ago)

Author:

djpaul

Message:

xProfile: fix regression in wp-admin field types screen where duplicate field templates were being shown for pre-2.0 custom field types.

A switch statement in the original xprofile_admin_field() was mis-read and an action was being triggered when it shouldn't have, causing the field templates to double up.
Fixes backwards compatibility with existing plugins that add custom field types.

Fixes #5511

File:

• trunk/bp-xprofile/bp-xprofile-admin.php (modified) (1 diff)

trunk/bp-xprofile/bp-xprofile-admin.php

@@ -384 +384 @@
 
             <?php
-            $field_type = bp_xprofile_create_field_type( $field->type );
-            $field_type->admin_field_html();
-
-            do_action( 'xprofile_admin_field', $field, 1 );
+            if ( in_array( $field->type, array_keys( bp_xprofile_get_field_types() ) ) ) {
+                $field_type = bp_xprofile_create_field_type( $field->type );
+                $field_type->admin_field_html();
+
+            } else {
+                do_action( 'xprofile_admin_field', $field, 1 );
+            }
             ?>