Changeset 8196

Timestamp:

03/29/2014 12:04:49 AM (11 years ago)

Author:

imath

Message:

Remove the bp_get_signup_allowed() checks in Sign-ups management feature

• Create $wpdb->signups table even if sign-ups are not allowed on single blog config
• Display the UI to manage sign-ups even if signups are not allowed

This way, administrator who temporarly deactivated registrations will still be able to moderate the pending signups.

props johnjamesjacoby, boonebgorges

See #5374

Location:

trunk

Files:

• bp-core/admin/bp-core-schema.php (modified) (1 diff)
• bp-core/bp-core-update.php (modified) (1 diff)
• bp-members/bp-members-admin.php (modified) (2 diffs)

trunk/bp-core/admin/bp-core-schema.php

@@ -53 +53 @@
 
     // Install the signups table
-    if ( bp_get_signup_allowed() )
-        bp_core_install_signups();
+    bp_core_install_signups();
 
 }

trunk/bp-core/bp-core-update.php

@@ -353 +353 @@
     /** Migrate signups data **************************************************/
 
-    if ( bp_get_signup_allowed() && ! is_multisite() ) {
+    if ( ! is_multisite() ) {
 
         if ( empty( $wpdb->signups ) ) {

trunk/bp-members/bp-members-admin.php

@@ -163 +163 @@
         /** Signups **************************************************************/
 
-        if ( bp_get_signup_allowed() && is_admin() ) {
+        if ( is_admin() ) {
             if ( ! is_multisite() ) {
                 add_action( 'pre_user_query', array( $this, 'remove_signups_from_user_query'),  10, 1 );
@@ -195 +195 @@
         );
 
-        // Manage signups if allowed
-        if ( bp_get_signup_allowed() ) {
-            $hooks['signups'] = $this->signups_page = add_users_page(
-                __( 'Manage Signups',  'buddypress' ),
-                __( 'Manage Signups',  'buddypress' ),
-                $this->capability,
-                'bp-signups',
-                array( &$this, 'signups_admin' )
-            );
-        }
+        // Manage signups
+        $hooks['signups'] = $this->signups_page = add_users_page(
+            __( 'Manage Signups',  'buddypress' ),
+            __( 'Manage Signups',  'buddypress' ),
+            $this->capability,
+            'bp-signups',
+            array( &$this, 'signups_admin' )
+        );
 
         $edit_page = 'user-edit';