Changeset 8192

Timestamp:

03/28/2014 11:14:15 PM (10 years ago)

Author:

r-a-y

Message:

Introduce bp_activity_admin_get_activity_actions().

This function walks through all currently registered activity actions
and returns a flattened array of the activity actions.

Format returned is:

Array(

'activity_update' => 'Posted a new status update',
...

)

See #5484

File:

• trunk/bp-activity/bp-activity-admin.php (modified) (2 diffs)

trunk/bp-activity/bp-activity-admin.php

@@ -459 +459 @@
         // Activity type
         if ( ! empty( $_POST['bp-activities-type'] ) ) {
-            $actions  = array();
-
-            // Walk through the registered actions, and build an array of actions/values.
-            foreach ( $bp->activity->actions as $action ) {
-                $action = array_values( (array) $action );
-
-                for ( $i = 0, $i_count = count( $action ); $i < $i_count; $i++ )
-                    $actions[] = $action[$i]['key'];
+            $actions = bp_activity_admin_get_activity_actions();
+
+            // Check that the new type is a registered activity type
+            if ( in_array( $_POST['bp-activities-type'], $actions ) ) {
+                $activity->type = $_POST['bp-activities-type'];
             }
-
-            // This was a mis-named activity type from before BP 1.6
-            unset( $actions['friends_register_activity_action'] );
-
-            // Check that the new type is a registered activity type
-            if ( in_array( $_POST['bp-activities-type'], $actions ) )
-                $activity->type = $_POST['bp-activities-type'];
         }
 
@@ -737 +727 @@
 
 /**
+ * Get flattened array of all registered activity actions.
+ *
+ * Format is [activity_type] => Pretty name for activity type.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @return array
+ */
+function bp_activity_admin_get_activity_actions() {
+    $actions  = array();
+
+    // Walk through the registered actions, and build an array of actions/values.
+    foreach ( buddypress()->activity->actions as $action ) {
+        $action = array_values( (array) $action );
+
+        for ( $i = 0, $i_count = count( $action ); $i < $i_count; $i++ ) {
+            $actions[ $action[$i]['key'] ] = $action[$i]['value'];
+        }
+    }
+
+    // This was a mis-named activity type from before BP 1.6
+    unset( $actions['friends_register_activity_action'] );
+
+    // Sort array by the human-readable value
+    natsort( $actions );
+
+    return $actions;
+}
+
+/**
  * Activity type metabox for the Activity admin edit screen
  *