Changeset 8189

Timestamp:

03/28/2014 10:33:16 PM (11 years ago)

Author:

r-a-y

Message:

Blogs: Mirror a blog's various comment options to BP's blogmeta.

This commit mirrors the following blog options to BP's blogmeta:

• 'close_comments_for_old_posts'
• 'close_comment_days_old'
• 'thread_comments_depth'

These options will be used later in the new bp_blogs_comments_open()
function to determine whether a blog post's activity item should be
closed from commenting. This is designed to prevent multiple calls
to switch_to_blog().

See #5130

Location:

trunk/bp-blogs

Files:

• bp-blogs-activity.php (modified) (1 diff)
• bp-blogs-functions.php (modified) (3 diffs)

trunk/bp-blogs/bp-blogs-activity.php

@@ -346 +346 @@
     ) );
 }
+
+/**
+ * Check if a blog post's activity item should be closed from commenting.
+ *
+ * This mirrors the {@link comments_open()} and {@link _close_comments_for_old_post()}
+ * functions, but for use with the BuddyPress activity stream to be as
+ * lightweight as possible.
+ *
+ * By lightweight, we actually mirror a few of the blog's commenting settings
+ * to blogmeta and checks the values in blogmeta instead.  This is to prevent
+ * multiple {@link switch_to_blog()} calls in the activity stream.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param object $activity The BP_Activity_Activity object
+ * @return bool
+ */
+function bp_blogs_comments_open( $activity ) {
+    $open = true;
+
+    $blog_id = $activity->item_id;
+
+    // see if we've mirrored the close comments option before
+    $days_old = bp_blogs_get_blogmeta( $blog_id, 'close_comments_days_old' );
+
+    // we've never cached these items before, so do it now
+    if ( '' === $days_old ) {
+        switch_to_blog( $blog_id );
+
+        // use comments_open()
+        remove_filter( 'comments_open', 'bp_comments_open', 10, 2 );
+        $open = comments_open( $activity->secondary_item_id );
+        add_filter( 'comments_open', 'bp_comments_open', 10, 2 );
+
+        // might as well mirror values to blogmeta since we're here!
+        $thread_depth = get_option( 'thread_comments' );
+        if ( ! empty( $thread_depth ) ) {
+            $thread_depth = get_option( 'thread_comments_depth' );
+        } else {
+            // perhaps filter this?
+            $thread_depth = 1;
+        }
+
+        bp_blogs_update_blogmeta( $blog_id, 'close_comments_for_old_posts', get_option( 'close_comments_for_old_posts' ) );
+        bp_blogs_update_blogmeta( $blog_id, 'close_comments_days_old',      get_option( 'close_comments_days_old' ) );
+        bp_blogs_update_blogmeta( $blog_id, 'thread_comments_depth',        $thread_depth );
+
+        restore_current_blog();
+
+    // check blogmeta and manually check activity item
+    // basically a copy of _close_comments_for_old_post()
+    } else {
+
+        // comments are closed
+        if ( 'closed' == bp_activity_get_meta( $activity->id, 'post_comment_status' ) ) {
+            return false;
+        }
+
+        if ( ! bp_blogs_get_blogmeta( $blog_id, 'close_comments_for_old_posts' ) ) {
+            return $open;
+        }
+
+        $days_old = (int) $days_old;
+        if ( ! $days_old ) {
+            return $open;
+        }
+
+        /* commenting out for now - needs some more thought...
+           should we add the post type to activity meta?
+
+        $post = get_post($post_id);
+
+        // This filter is documented in wp-includes/comment.php
+        $post_types = apply_filters( 'close_comments_for_post_types', array( 'post' ) );
+        if ( ! in_array( $post->post_type, $post_types ) )
+            return $open;
+        */
+
+        if ( time() - strtotime( $activity->date_recorded ) > ( $days_old * DAY_IN_SECONDS ) ) {
+            return false;
+        }
+
+        return $open;
+    }
+
+    return $open;
+}

trunk/bp-blogs/bp-blogs-functions.php

@@ -183 +183 @@
         return false;
 
-    $url         = get_home_url( $blog_id );
-    $name        = get_blog_option( $blog_id, 'blogname' );
-    $description = get_blog_option( $blog_id, 'blogdescription' );
-
-    if ( empty( $name ) )
-        return false;
+    $name = get_blog_option( $blog_id, 'blogname' );
+
+    if ( empty( $name ) ) {
+        return false;
+    }
+
+    $url             = get_home_url( $blog_id );
+    $description     = get_blog_option( $blog_id, 'blogdescription' );
+    $close_old_posts = get_blog_option( $blog_id, 'close_comments_for_old_posts' );
+    $close_days_old  = get_blog_option( $blog_id, 'close_comments_days_old' );
+
+    $thread_depth = get_blog_option( $blog_id, 'thread_comments' );
+    if ( ! empty( $thread_depth ) ) {
+        $thread_depth = get_blog_option( $blog_id, 'thread_comments_depth' );
+    } else {
+        // perhaps filter this?
+        $thread_depth = 1;
+    }
 
     $recorded_blog          = new BP_Blogs_Blog;
@@ -200 +212 @@
     bp_blogs_update_blogmeta( $recorded_blog->blog_id, 'description', $description );
     bp_blogs_update_blogmeta( $recorded_blog->blog_id, 'last_activity', bp_core_current_time() );
+    bp_blogs_update_blogmeta( $recorded_blog->blog_id, 'close_comments_for_old_posts', $close_old_posts );
+    bp_blogs_update_blogmeta( $recorded_blog->blog_id, 'close_comments_days_old', $close_days_old );
+    bp_blogs_update_blogmeta( $recorded_blog->blog_id, 'thread_comments_depth', $thread_depth );
 
     $is_private = !empty( $_POST['blog_public'] ) && (int) $_POST['blog_public'] ? false : true;
@@ -251 +266 @@
 }
 add_action( 'update_option_blogdescription', 'bp_blogs_update_option_blogdescription', 10, 2 );
+
+/**
+ * Update "Close comments for old posts" option in BuddyPress blogmeta table.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @global object $wpdb DB Layer.
+ *
+ * @param string $oldvalue Value before save. Passed by do_action() but
+ *        unused here.
+ * @param string $newvalue Value to change meta to.
+ */
+function bp_blogs_update_option_close_comments_for_old_posts( $oldvalue, $newvalue ) {
+    global $wpdb;
+
+    bp_blogs_update_blogmeta( $wpdb->blogid, 'close_comments_for_old_posts', $newvalue );
+}
+add_action( 'update_option_close_comments_for_old_posts', 'bp_blogs_update_option_close_comments_for_old_posts', 10, 2 );
+
+/**
+ * Update "Close comments after days old" option in BuddyPress blogmeta table.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @global object $wpdb DB Layer.
+ *
+ * @param string $oldvalue Value before save. Passed by do_action() but
+ *        unused here.
+ * @param string $newvalue Value to change meta to.
+ */
+function bp_blogs_update_option_close_close_comments_days_old( $oldvalue, $newvalue ) {
+    global $wpdb;
+
+    bp_blogs_update_blogmeta( $wpdb->blogid, 'close_comments_days_old', $newvalue );
+}
+add_action( 'update_option_close_comments_days_old', 'bp_blogs_update_option_close_comments_days_old', 10, 2 );
+
+/**
+ * When toggling threaded comments, update thread depth in blogmeta table.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @global object $wpdb DB Layer.
+ *
+ * @param string $oldvalue Value before save. Passed by do_action() but
+ *        unused here.
+ * @param string $newvalue Value to change meta to.
+ */
+function bp_blogs_update_option_thread_comments( $oldvalue, $newvalue ) {
+    global $wpdb;
+
+    if ( empty( $newvalue ) ) {
+        $thread_depth = 1;
+    } else {
+        $thread_depth = get_option( 'thread_comments_depth' );
+    }
+
+    bp_blogs_update_blogmeta( $wpdb->blogid, 'thread_comments_depth', $thread_depth );
+}
+add_action( 'update_option_thread_comments', 'bp_blogs_update_option_thread_comments', 10, 2 );
+
+/**
+ * When updating comment depth, update thread depth in blogmeta table.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @global object $wpdb DB Layer.
+ *
+ * @param string $oldvalue Value before save. Passed by do_action() but
+ *        unused here.
+ * @param string $newvalue Value to change meta to.
+ */
+function bp_blogs_update_option_thread_comments_depth( $oldvalue, $newvalue ) {
+    global $wpdb;
+
+    $comments_enabled = get_option( 'thread_comments' );
+
+    if (  $comments_enabled ) {
+        bp_blogs_update_blogmeta( $wpdb->blogid, 'thread_comments_depth', $newvalue );
+    }
+}
+add_action( 'update_option_thread_comments_depth', 'bp_blogs_update_option_thread_comments_depth', 10, 2 );
 
 /**