Skip to:
Content

BuddyPress.org

Changeset 8172


Ignore:
Timestamp:
03/27/2014 05:37:38 PM (10 years ago)
Author:
boonebgorges
Message:

Return false friends_add_friend() when the initiator is the same as the friend

It's good to love yourself, but there's no real reason to allow
self-friendships in BuddyPress.

See #5319

Props megainfo, r-a-y

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-friends/bp-friends-functions.php

    r7673 r8172  
    3030 */
    3131function friends_add_friend( $initiator_userid, $friend_userid, $force_accept = false ) {
     32
     33    // You cannot be friends with yourself!
     34    if ( $initiator_userid == $friend_userid ) {
     35        return false;
     36    }
    3237
    3338    // Check if already friends, and bail if so
  • trunk/tests/testcases/friends/functions.php

    r8112 r8172  
    116116        $this->set_current_user( $old_user );
    117117    }
     118
     119    /**
     120     * @group friends_add_friend
     121     */
     122    public function test_friends_add_friend_fail_on_self() {
     123        $u1 = $this->create_user();
     124        $this->assertFalse( friends_add_friend( $u1, $u1 ) );
     125    }
    118126}
Note: See TracChangeset for help on using the changeset viewer.