Changeset 8136

Timestamp:

03/15/2014 10:54:27 AM (12 years ago)

Author:

imath

Message:

Display a Manage Signups submenu to Users menu in wp-admin

Signups management is simulating a new view in the wp-admin users page. A Pending link is available after the different WordPress views to filter the users by roles. It appears the Signups screen can be a bit difficult to find for site or network administrators. As a result, it is best to display the Manage Signups submenu instead of removing it.

See #5374

props johnjamesjacoby, boonebgorges

Location:

trunk/bp-members

Files:

• admin/bp-members-classes.php (modified) (2 diffs)
• bp-members-admin.php (modified) (5 diffs)

trunk/bp-members/admin/bp-members-classes.php

@@ -100 +100 @@
                 // Remove the 'current' class from the 'All' link
                 $views['all']        = str_replace( 'class="current"', '', $views['all'] );
-                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"  class="current">' . sprintf( _nx( 'Pending account <span class="count">(%s)</span>', 'Pending accounts <span class="count">(%s)</span>', $this->signup_counts, 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
+                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"  class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
 
                 return $views;
@@ -415 +415 @@
                         $class = ' class="current"';
 
-                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"  class="current">' . sprintf( _nx( 'Pending account <span class="count">(%s)</span>', 'Pending accounts <span class="count">(%s)</span>', $this->signup_counts, 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
+                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"  class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
 
                 return $views;

trunk/bp-members/bp-members-admin.php

@@ -203 +203 @@
 
                 foreach ( $hooks as $key => $hook ) {
-                        add_action( "admin_head-$hook", array( $this, 'modify_admin_menu_highlight' ) );
                         add_action( "load-$hook",       array( $this, $key . '_admin_load' ) );
                 }
 
-        }
-
-        /**
-         * Highlight the Users menu if on Edit Profile or Signups pages.
+                add_action( "admin_head-$this->user_page", array( $this, 'modify_admin_menu_highlight' ) );
+
+        }
+
+        /**
+         * Highlight the Users menu if on Edit Profile.
          *
          * @access public
@@ -219 +220 @@
 
                 // Only Show the All users menu
-                if ( in_array( $plugin_page, array( 'bp-profile-edit', 'bp-signups' ) ) ) {
+                if ( $plugin_page = 'bp-profile-edit' ) {
                         $submenu_file = 'users.php';
                 }
@@ -225 +226 @@
 
         /**
-         * Remove the Edit Profile & Signups submenu page.
+         * Remove the Edit Profile page.
          *
          * We add these pages in order to integrate with WP's Users panel, but
-         * we want them to show up as Views of the WP panel, not as separate
+         * we want them to show up as a row action of the WP panel, not as separate
          * subnav items under the Users menu.
          *
@@ -237 +238 @@
                 // Remove submenu to force using Profile Navigation
                 remove_submenu_page( 'users.php', 'bp-profile-edit' );
-
-                // Remove submenu to force using users views
-                remove_submenu_page( 'users.php', 'bp-signups' );
         }
 
@@ -808 +806 @@
                 }
 
-                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"' . $class . '>' . sprintf( _nx( 'Pending <span class="count">(%s)</span>', 'Pending <span class="count">(%s)</span>', $signups, 'signup users', 'buddypress' ), number_format_i18n( $signups ) ) . '</a>';
+                $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"' . $class . '>' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $signups ) ) . '</a>';
 
                 return $views;