Changeset 8135 for trunk/bp-activity/bp-activity-functions.php

Timestamp:

03/14/2014 01:12:13 AM (11 years ago)

Author:

boonebgorges

Message:

Remove unnecessary parameter sanitization from meta functions

WP's meta API functions already perform the necessary sanitization.

See #5399

File:

• trunk/bp-activity/bp-activity-functions.php (modified) (3 diffs)

trunk/bp-activity/bp-activity-functions.php

@@ -572 +572 @@
     global $wpdb, $bp;
 
-    // Legacy - Return false if any of the above values are not set
-    if ( ! is_numeric( $activity_id ) ) {
-        return false;
-    }
-
     // Legacy - if no meta_key is passed, delete all for the item
     if ( empty( $meta_key ) ) {
@@ -616 +611 @@
  */
 function bp_activity_get_meta( $activity_id = 0, $meta_key = '', $single = true ) {
-
-    // Make sure activity_id is valid
-    if ( empty( $activity_id ) || ! is_numeric( $activity_id ) ) {
-        return false;
-    }
-
     add_filter( 'query', 'bp_filter_metaid_column_name' );
     $retval = get_metadata( 'activity', $activity_id, $meta_key, $single );
@@ -647 +636 @@
  */
 function bp_activity_update_meta( $activity_id, $meta_key, $meta_value, $prev_value = '' ) {
-
-    // Legacy - Make sure activity_id is valid
-    if ( ! is_numeric( $activity_id ) ) {
-        return false;
-    }
-
     add_filter( 'query', 'bp_filter_metaid_column_name' );
     $retval = update_metadata( 'activity', $activity_id, $meta_key, $meta_value, $prev_value );