Changeset 8133 for trunk/tests/testcases/activity/functions.php

Timestamp:

03/14/2014 01:04:58 AM (11 years ago)

Author:

boonebgorges

Message:

Use WP's array format for get_meta() functions when no $meta_key is provided

Passing only an object_id to a get_meta() function in WP will return an array
of arrays, keyed by meta_keys, each containing a list of meta_values for that
meta_key. BP's get_meta() functions were inconsistent in this regard: some
returned arrays of stdClass, some returned one-d arrays of meta_values. All
returned values that were practically of little use, because they didn't have
enough information about the located data to make it useful.

This changeset aligns BP's get_meta() functions with WP's. We now allow the
return value of get_metadata() to pass through untouched in all cases. Unit
tests have been updated as necessary.

See #5399

File:

• trunk/tests/testcases/activity/functions.php (modified) (2 diffs)

trunk/tests/testcases/activity/functions.php

@@ -83 +83 @@
 
         // test if activity meta entries still exist
-        $this->assertEquals( false, $m1 );
-        $this->assertEquals( false, $m2 );
-        $this->assertEquals( false, $m3 );
+        $this->assertEmpty( $m1 );
+        $this->assertEmpty( $m2 );
+        $this->assertEmpty( $m3 );
     }
 
@@ -251 +251 @@
         bp_activity_update_meta( $a, 'foo1', 'bar1' );
 
-        $am1 = new stdClass;
-        $am1->meta_key = 'foo';
-        $am1->meta_value = 'bar';
-
-        $am2 = new stdClass;
-        $am2->meta_key = 'foo1';
-        $am2->meta_value = 'bar1';
-
         $expected = array(
-            $am1,
-            $am2,
+            'foo' => array(
+                'bar',
+            ),
+            'foo1' => array(
+                'bar1',
+            ),
         );