Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/14/2014 01:04:58 AM (10 years ago)
Author:
boonebgorges
Message:

Use WP's array format for get_meta() functions when no $meta_key is provided

Passing only an object_id to a get_meta() function in WP will return an array
of arrays, keyed by meta_keys, each containing a list of meta_values for that
meta_key. BP's get_meta() functions were inconsistent in this regard: some
returned arrays of stdClass, some returned one-d arrays of meta_values. All
returned values that were practically of little use, because they didn't have
enough information about the located data to make it useful.

This changeset aligns BP's get_meta() functions with WP's. We now allow the
return value of get_metadata() to pass through untouched in all cases. Unit
tests have been updated as necessary.

See #5399

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-xprofile/bp-xprofile-functions.php

    r8132 r8133  
    641641    remove_filter( 'query', 'bp_xprofile_filter_meta_query' );
    642642
    643     // Legacy - if no meta_key is provided, return just the located
    644     // values (not a structured array)
    645     if ( empty( $meta_key ) && ! empty( $retval ) ) {
    646         $values = array();
    647         foreach ( $retval as $v ) {
    648             $values[] = array_pop( $v );
    649         }
    650 
    651         $retval = $values;
    652     }
    653 
    654643    return $retval;
    655644}
Note: See TracChangeset for help on using the changeset viewer.