Changeset 8133 for trunk/bp-xprofile/bp-xprofile-functions.php

Timestamp:

03/14/2014 01:04:58 AM (11 years ago)

Author:

boonebgorges

Message:

Use WP's array format for get_meta() functions when no $meta_key is provided

Passing only an object_id to a get_meta() function in WP will return an array
of arrays, keyed by meta_keys, each containing a list of meta_values for that
meta_key. BP's get_meta() functions were inconsistent in this regard: some
returned arrays of stdClass, some returned one-d arrays of meta_values. All
returned values that were practically of little use, because they didn't have
enough information about the located data to make it useful.

This changeset aligns BP's get_meta() functions with WP's. We now allow the
return value of get_metadata() to pass through untouched in all cases. Unit
tests have been updated as necessary.

See #5399

File:

• trunk/bp-xprofile/bp-xprofile-functions.php (modified) (1 diff)

trunk/bp-xprofile/bp-xprofile-functions.php

@@ -641 +641 @@
     remove_filter( 'query', 'bp_xprofile_filter_meta_query' );
 
-    // Legacy - if no meta_key is provided, return just the located
-    // values (not a structured array)
-    if ( empty( $meta_key ) && ! empty( $retval ) ) {
-        $values = array();
-        foreach ( $retval as $v ) {
-            $values[] = array_pop( $v );
-        }
-
-        $retval = $values;
-    }
-
     return $retval;
 }