Changeset 8131 for trunk/tests/testcases/groups/functions.php

Timestamp:

03/14/2014 12:37:28 AM (11 years ago)

Author:

boonebgorges

Message:

Return an empty string from get_meta() functions when no value is found

BP get_meta() functions have been inconsistent about the type of value returned
when no match is found for the object_id+meta_key combination. In some cases,
we followed WP's get_metadata() and returned an empty string. In others, we
returned false.

This changeset aligns all of our get_meta() functions with WP in this regard,
returning an empty string when no matching value is found. A boolean false is
still returned when invalid arguments are passed to the functions.

Relevant unit tests have been updated, including strict assertSame() checking
where appropriate.

See #5399

File:

• trunk/tests/testcases/groups/functions.php (modified) (3 diffs)

trunk/tests/testcases/groups/functions.php

@@ -308 +308 @@
     public function test_groups_update_groupmeta_new() {
         $g = $this->factory->group->create();
-        $this->assertEquals( '', groups_get_groupmeta( $g, 'foo' ), '"foo" meta should be empty for this group.' );
+        $this->assertSame( '', groups_get_groupmeta( $g, 'foo' ), '"foo" meta should be empty for this group.' );
         $this->assertTrue( groups_update_groupmeta( $g, 'foo', 'bar' ) );
         $this->assertSame( 'bar', groups_get_groupmeta( $g, 'foo' ) );
@@ -365 +365 @@
 
         $krazy_key = ' f!@#$%^o *(){}o?+';
-        $this->assertEmpty( groups_get_groupmeta( $g, $krazy_key ) );
+        $this->assertSame( '', groups_get_groupmeta( $g, $krazy_key ) );
     }
 
@@ -509 +509 @@
 
         $this->assertTrue( groups_delete_groupmeta( $g1, 'foo', '', true ) );
-        $this->assertEmpty( '', groups_get_groupmeta( $g1, 'foo' ) );
-        $this->assertEmpty( '', groups_get_groupmeta( $g2, 'foo' ) );
+        $this->assertSame( '', groups_get_groupmeta( $g1, 'foo' ) );
+        $this->assertSame( '', groups_get_groupmeta( $g2, 'foo' ) );
         $this->assertSame( 'bar1', groups_get_groupmeta( $g1, 'foo1' ) );
         $this->assertSame( 'bar1', groups_get_groupmeta( $g2, 'foo1' ) );