Changeset 8130 for trunk/bp-activity/bp-activity-functions.php

Timestamp:

03/14/2014 12:15:41 AM (10 years ago)

Author:

boonebgorges

Message:

Don't trim whitespace from $meta_value param in _delete_meta() functions

The $meta_value parameter of BP's delete_meta() functions allows developers to
limit deletion to rows that match both the $meta_key *and* the specified
$meta_value. However, most of BP's delete_meta() functions have always had a
quirk whereby the $meta_value was run through trim() before matching against
the values in the database. This had the unacceptable side effect that passing
a $meta_value of ' foo ' would delete rows with the value 'foo', but *not*
the value ' foo '!

This changeset reverses the behavior, and modifies the relevant unit tests.

See #5399

File:

• trunk/bp-activity/bp-activity-functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-functions.php

@@ -576 +576 @@
         return false;
     }
-
-    // Legacy - Trim off whitespace
-    $meta_value = trim( $meta_value );
 
     // Legacy - if no meta_key is passed, delete all for the item