Changeset 8129 for trunk/tests/testcases/blogs/functions.php

Timestamp:

03/14/2014 12:07:18 AM (11 years ago)

Author:

boonebgorges

Message:

Don't improperly sanitize meta_key in _meta() functions

Many BP meta functions have always stripped certain characters from the
$meta_key parameter before performing their operations. This is a terrible idea
on a number of levels: it doesn't provide any feedback to the user, it silently
performs actions that are not equivalent to the ones intended by the user, and
it doesn't serve any real purpose (since any necessary sanitization happens at
the level of $wpdb). Moreover, it wasn't even applied consistently across all
functions. A truly delightful grab bag.

This changeset removes the sanitization, and updates the necessary unit tests
to reflect the change.

See #5399

File:

• trunk/tests/testcases/blogs/functions.php (modified) (4 diffs)

trunk/tests/testcases/blogs/functions.php

@@ -16 +16 @@
      * @group blogmeta
      * @group bp_blogs_delete_blogmeta
+     * @ticket BP5399
      */
     public function test_bp_blogs_delete_blogmeta_illegal_characters() {
@@ -21 +22 @@
         $this->assertSame( 'bar', bp_blogs_get_blogmeta( 1, 'foo' ) );
         $krazy_key = ' f!@#$%^o *(){}o?+';
-        $this->assertTrue( bp_blogs_delete_blogmeta( 1, $krazy_key ) );
-        $this->assertSame( '', bp_blogs_get_blogmeta( 1, 'foo' ) );
+        $this->assertFalse( bp_blogs_delete_blogmeta( 1, $krazy_key ) );
+        $this->assertSame( 'bar', bp_blogs_get_blogmeta( 1, 'foo' ) );
     }
 
@@ -110 +111 @@
      * @group blogmeta
      * @group bp_blogs_get_blogmeta
+     * @ticket BP5399
      */
     public function test_bp_blogs_get_blogmeta_illegal_characters() {
         bp_blogs_update_blogmeta( 1, 'foo', 'bar' );
         $krazy_key = ' f!@#$%^o *(){}o?+';
-        $this->assertSame( 'bar', bp_blogs_get_blogmeta( 1, $krazy_key ) );
+        $this->assertEmpty( bp_blogs_get_blogmeta( 1, $krazy_key ) );
     }
 
@@ -167 +169 @@
      * @group blogmeta
      * @group bp_blogs_update_blogmeta
+     * @ticket BP5399
      */
     public function test_bp_blogs_update_blogmeta_illegal_characters() {
         $krazy_key = ' f!@#$%^o *(){}o?+';
         bp_blogs_update_blogmeta( 1, $krazy_key, 'bar' );
-        $this->assertSame( 'bar', bp_blogs_get_blogmeta( 1, 'foo' ) );
+        $this->assertEmpty( bp_blogs_get_blogmeta( 1, 'foo' ) );
     }