Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/09/2014 02:38:24 PM (10 years ago)
Author:
boonebgorges
Message:

Improve strings used for <title> and header of directory pages

Our legacy method for creating directory titles involved concatenating the
component name into '% Directory', which did not work well in languages where
a term like 'Groups Directory' would be translated into a single word. In
addition, there was inconistency between the <title> element on directory pages
and the header element used in the page body.

This changeset introduces a 'directory_title' parameter to BP_Core_Component,
so that directories can register a fully localizable string as the title/
header for directories.

To avoid filter name conflicts, the filter names associated with the headers
on group and blog directory pages were changed to _directory_header. See r7942,

See #4726, #4630

Fixes #4631

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-core/bp-core-filters.php

    r8033 r8090  
    432432    // An index or directory
    433433    } elseif ( bp_is_directory() ) {
    434         if ( !bp_current_component() ) {
    435             $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug() );
     434
     435        $current_component = bp_current_component();
     436
     437        // No current component (when does this happen?)
     438        if ( empty( $current_component ) ) {
     439            $title = _x( 'Directory', 'component directory title', 'buddypress' );
    436440        } else {
    437             $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug() );
     441            $title = bp_get_directory_title( $current_component );
    438442        }
    439443
Note: See TracChangeset for help on using the changeset viewer.