Changeset 8090 for trunk/bp-core/bp-core-filters.php

Timestamp:

03/09/2014 02:38:24 PM (11 years ago)

Author:

boonebgorges

Message:

Improve strings used for <title> and header of directory pages

Our legacy method for creating directory titles involved concatenating the
component name into '% Directory', which did not work well in languages where
a term like 'Groups Directory' would be translated into a single word. In
addition, there was inconistency between the <title> element on directory pages
and the header element used in the page body.

This changeset introduces a 'directory_title' parameter to BP_Core_Component,
so that directories can register a fully localizable string as the title/
header for directories.

To avoid filter name conflicts, the filter names associated with the headers
on group and blog directory pages were changed to _directory_header. See r7942,

See #4726, #4630

Fixes #4631

File:

• trunk/bp-core/bp-core-filters.php (modified) (1 diff)

trunk/bp-core/bp-core-filters.php

@@ -432 +432 @@
     // An index or directory
     } elseif ( bp_is_directory() ) {
-        if ( !bp_current_component() ) {
-            $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug() );
+
+        $current_component = bp_current_component();
+
+        // No current component (when does this happen?)
+        if ( empty( $current_component ) ) {
+            $title = _x( 'Directory', 'component directory title', 'buddypress' );
         } else {
-            $title = sprintf( __( '%s Directory', 'buddypress' ), bp_get_name_from_root_slug() );
+            $title = bp_get_directory_title( $current_component );
         }