Changeset 8085 for trunk/bp-activity/bp-activity-admin.php

Timestamp:

03/08/2014 08:05:32 PM (12 years ago)

Author:

boonebgorges

Message:

Better fallback support on Activity Admin for items with an unregistered type

The 'Type' dropdown on the activity edit screen is populated with types that
have been registered with bp_activity_set_action(). However, many legacy
plugins do not register their activity types correctly. This adds support
for editing these types of activity items.

Fixes #4786

File:

• trunk/bp-activity/bp-activity-admin.php (modified) (1 diff)

trunk/bp-activity/bp-activity-admin.php

@@ -763 +763 @@
 
     // Sort array by the human-readable value
-    natsort( $actions ); ?>
+    natsort( $actions );
+
+    // If the activity type is not registered properly (eg, a plugin has
+    // not called bp_activity_set_action()), add the raw type to the end
+    // of the list
+    if ( ! isset( $actions[ $selected ] ) ) {
+        _doing_it_wrong( __FUNCTION__, sprintf( __( 'This activity item has a type (%s) that is not registered using bp_activity_set_action(), so no label is available.', 'buddypress' ), $selected ), '2.0.0' );
+        $actions[ $selected ] = $selected;
+    }
+
+    ?>
 
     <select name="bp-activities-type">