Changeset 8082 for trunk/tests/testcases/xprofile/functions.php

Timestamp:

03/08/2014 12:33:18 PM (11 years ago)

Author:

boonebgorges

Message:

Improve behavior or bp_member_profile_data() when used outside of members loop

Our documentation suggests the use of bp_member_profile_data() to pull up
miscellaneous pieces of user profile data anywhere in a template. Technically,
this works, but the internals of the function made a few assumptions that it
would only be used in the context of a bp_has_members() loop. This would result
in needless PHP notices when using the function outside of a loop context.

This changeset introduces checks to ensure that the $members_template global
is only manipulated if it exists, making the function safe to use anywhere.

Fixes #5334

File:

• trunk/tests/testcases/xprofile/functions.php (modified) (1 diff)

trunk/tests/testcases/xprofile/functions.php

@@ -496 +496 @@
         $this->assertNotEmpty( bp_xprofile_add_meta( $g, 'group', 'foo', 'baz' ) );
     }
+
+    /**
+     * @group bp_get_member_profile_data
+     */
+    public function test_bp_get_member_profile_data_inside_loop() {
+        $u = $this->create_user();
+        $g = $this->factory->xprofile_group->create();
+        $f = $this->factory->xprofile_field->create( array(
+            'field_group_id' => $g,
+            'type' => 'textbox',
+            'name' => 'Neato',
+        ) );
+        xprofile_set_field_data( $f, $u, 'foo' );
+
+        if ( bp_has_members() ) : while ( bp_members() ) : bp_the_member();
+        $found = bp_get_member_profile_data( array(
+            'user_id' => $u,
+            'field' => 'Neato',
+        ) );
+        endwhile; endif;
+
+        // Cleanup
+        unset( $GLOBALS['members_template'] );
+
+        $this->assertSame( 'foo', $found );
+    }
+    /**
+     * @group bp_get_member_profile_data
+     */
+    public function test_bp_get_member_profile_data_outside_of_loop() {
+        $u = $this->create_user();
+        $g = $this->factory->xprofile_group->create();
+        $f = $this->factory->xprofile_field->create( array(
+            'field_group_id' => $g,
+            'type' => 'textbox',
+            'name' => 'Kewl',
+        ) );
+        xprofile_set_field_data( $f, $u, 'foo' );
+
+        $found = bp_get_member_profile_data( array(
+            'user_id' => $u,
+            'field' => 'Kewl',
+        ) );
+
+        $this->assertSame( 'foo', $found );
+    }
 }