Changeset 8076 for trunk/bp-activity/bp-activity-functions.php

Timestamp:

03/07/2014 01:32:04 AM (12 years ago)

Author:

boonebgorges

Message:

Improved cache invalidation when posting activity comments

• Because activity comment caches are stored only with the top-level parent, we should be invalidating the bp_activity_comments cache for that item, not for the immediate parent
• When a new comment is created, clear the bp_activity cache for each ancestor

See #5434

File:

• trunk/bp-activity/bp-activity-functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-functions.php

@@ -1241 +1241 @@
     ) );
 
-    // Clear the comment and item cache for this activity
-    wp_cache_delete( $parent_id, 'bp_activity_comments' );
-    wp_cache_delete( $parent_id, 'bp_activity' );
+    // Comment caches are stored only with the top-level item
+    wp_cache_delete( $activity_id, 'bp_activity_comments' );
+
+    // Walk the tree to clear caches for all parent items
+    $clear_id = $parent_id;
+    while ( $clear_id != $activity_id ) {
+        $clear_object = new BP_Activity_Activity( $clear_id );
+        wp_cache_delete( $clear_id, 'bp_activity' );
+        $clear_id = intval( $clear_object->secondary_item_id );
+    }
+    wp_cache_delete( $activity_id, 'bp_activity' );
 
     do_action( 'bp_activity_comment_posted', $comment_id, $params, $activity );