Changeset 8073 for trunk/bp-blogs/bp-blogs-functions.php

Timestamp:

03/06/2014 09:02:22 PM (11 years ago)

Author:

boonebgorges

Message:

Improved management of new_blog_post activity items at transition_post_status

Introduces bp_blogs_catch_transition_post_status(). This function, which
replaces bp_blogs_catch_published_post(), performs a similar task - determining
when a new blog post has been published, and recording the post in the activity
stream - but adds a corrolary for unpublishing that deletes the activity item.

Unit tests and deprecated function are included.

See #5333

Props henry.wright for an initial patch

File:

• trunk/bp-blogs/bp-blogs-functions.php (modified) (2 diffs)

trunk/bp-blogs/bp-blogs-functions.php

@@ -260 +260 @@
  * See #4090, #3746, #2546 for background.
  *
- * @since BuddyPress (1.9.0)
+ * @since BuddyPress (2.0.0)
  *
  * @param string $new_status New status for the post.
@@ -266 +266 @@
  * @param object $post Post data.
  */
-function bp_blogs_catch_published_post( $new_status, $old_status, $post ) {
-
-    // Only record published posts
-    if ( 'publish' !== $new_status ) {
+function bp_blogs_catch_transition_post_status( $new_status, $old_status, $post ) {
+
+    // Do nothing for edits
+    if ( $new_status === $old_status ) {
         return;
     }
 
-    // Don't record edits (publish -> publish)
-    if ( 'publish' === $old_status ) {
-        return;
-    }
-
-    return bp_blogs_record_post( $post->ID, $post );
-}
-add_action( 'transition_post_status', 'bp_blogs_catch_published_post', 10, 3 );
+    // Publishing a previously unpublished post
+    if ( 'publish' === $new_status ) {
+        return bp_blogs_record_post( $post->ID, $post );
+
+    // Unpublishing a previously published post
+    } else if ( 'publish' === $old_status ) {
+        return bp_blogs_remove_post( $post->ID );
+    }
+}
+add_action( 'transition_post_status', 'bp_blogs_catch_transition_post_status', 10, 3 );
 
 /**