Changeset 8054

Timestamp:

03/06/2014 01:31:01 AM (11 years ago)

Author:

boonebgorges

Message:

Ensure that a last_activity value is set for each user in BP_User_Query::populate_extras()

This helps to avoid PHP notices when directly accessing this value for a user
who has not yet logged activity.

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -574 +574 @@
         $last_activities = BP_Core_User::get_last_activity( $this->user_ids );
 
-        if ( ! empty( $last_activities ) ) {
-            foreach ( $last_activities as $la_user => $la_value ) {
-                if ( isset( $this->results[ $la_user ] ) ) {
-                    $this->results[ $la_user ]->last_activity = $la_value['date_recorded'];
-                }
-            }
+        // Set a last_activity value for each user, even if it's empty
+        foreach ( $this->results as $user_id => $user ) {
+            $user_last_activity = isset( $last_activities[ $user_id ] ) ? $last_activities[ $user_id ]['date_recorded'] : '';
+            $this->results[ $user_id ]->last_activity = $user_last_activity;
         }