Changeset 8047

Timestamp:

03/05/2014 06:11:16 PM (12 years ago)

Author:

r-a-y

Message:

Add object caching when fetching a single user's last activity.

Previously, BP_Core_User::get_last_activity() was not being cached.
This resulted in an unnecessary query being run on every page load due
to the usage of bp_core_record_activity() on the 'wp_head' action.

This commit caches calls to BP_Core_User::get_last_activity() when a
single user ID is passed and resets the cache when the user's last
activity is updated on BP_Core_User::update_last_activity().

See #5128

File:

• trunk/bp-core/bp-core-classes.php (modified) (6 diffs)

trunk/bp-core/bp-core-classes.php

@@ -1340 +1340 @@
                 }
 
+                // get cache for single user only
+                if ( ! is_array( $user_id ) ) {
+                        $cache = wp_cache_get( $user_id, 'bp_last_activity' );
+
+                        if ( false !== $cache ) {
+                                return $cache;
+                        }
+                }
+
                 $bp = buddypress();
 
@@ -1377 +1386 @@
                 $table_name = buddypress()->members->table_name_last_activity;
 
-                $existing = self::get_last_activity( $user_id );
-
-                if ( ! empty( $existing ) ) {
-                        $data = array(
-                                'date_recorded' => $time,
-                        );
-
-                        $data_format = array(
-                                '%s',
-                        );
-
-                        $where = array(
-                        );
-
-                        $where_format = array(
-                                '%d',
-                        );
-
+                $activity = self::get_last_activity( $user_id );
+
+                if ( ! empty( $activity ) ) {
                         $updated = $wpdb->update(
                                 $table_name,
@@ -1405 +1399 @@
                                 // WHERE
                                 array(
-                                        'id' => $existing[ $user_id ]['activity_id'],
+                                        'id' => $activity[ $user_id ]['activity_id'],
                                 ),
 
@@ -1418 +1412 @@
                                 )
                         );
+
+                        // add new date to existing activity entry for caching
+                        $activity[ $user_id ]['date_recorded'] = $time;
+
                 } else {
                         $updated = $wpdb->insert(
@@ -1446 +1444 @@
                                 )
                         );
-                }
+
+                        // setup activity array for caching
+                        // view the foreach loop in the get_last_activity() method for format
+                        $activity = array();
+                        $activity[ $user_id ] = array(
+                                'user_id'       => $user_id,
+                                'date_recorded' => $time,
+                                'activity_id'   => $wpdb->insert_id,
+                        );
+                }
+
+                // set cache
+                wp_cache_set( $user_id, $activity, 'bp_last_activity' );
 
                 return $updated;
@@ -1482 +1492 @@
                         )
                 );
+
+                wp_cache_delete( $user_id, 'bp_last_activity' );
 
                 return $deleted;