Changeset 8024

Timestamp:

03/03/2014 08:17:19 PM (11 years ago)

Author:

boonebgorges

Message:

Cache userdata after running WP_User_Query in BP_User_Query

WP_User_Query does not cache data that is stored in wp_users in a bulk fashion.
BP, on the other hand, does cache this data, as 'bp_core_userdata_' . $user_id.
This cached userdata is then referenced in many places throughout BP, including
the building of user_domains and userlinks. Thus, it can save up to 20 queries
per page (assuming per_page=20) during query loops.

A corresponding change has been made to the 'fields' parameter passed to
WP_User_Query from BP_User_Query. Because BP caches entire wp_users rows (see
BP_Core_User::get_core_userdata()), we must ensure that BP_User_Query is also
fetching entire rows. We opt not to use WP_User_Query's 'fields=all' parameter,
because it triggers the casting of WP_User objects, which in turn requires
expensive capability lookups.

See #5445

File:

• trunk/bp-core/bp-core-classes.php (modified) (2 diffs)

trunk/bp-core/bp-core-classes.php

@@ -450 +450 @@
 
             // Relevant
-            'fields'      => array( 'ID', 'user_registered', 'user_login', 'user_nicename', 'display_name', 'user_email' ),
+            'fields'      => array( 'ID', 'user_login', 'user_pass', 'user_nicename', 'user_email', 'user_url', 'user_registered', 'user_activation_key', 'user_status', 'display_name', 'spam', 'deleted' ),
             'include'     => $this->user_ids,
 
@@ -458 +458 @@
 
         ), $this ) );
+
+        // WP_User_Query doesn't cache the data it pulls from wp_users,
+        // and it does not give us a way to save queries by fetching
+        // only uncached users. However, BP does cache this data, so
+        // we set it here.
+        foreach ( $wp_user_query->results as $u ) {
+            wp_cache_set( 'bp_core_userdata_' . $u->ID, $u, 'bp' );
+        }
 
         // We calculate total_users using a standalone query, except