Changeset 8021

Timestamp:

03/02/2014 07:32:27 PM (11 years ago)

Author:

djpaul

Message:

xProfile: change the field visibility JS to show/hide the controls immediately, rather than with a slide/fade transition.

This helps improve the perceived performance of the visibility
controls. The code quality of these parts of the JS has also been
improved.

Fixes #5439

Location:

trunk

Files:

• bp-loader.php (modified) (1 diff)
• bp-members/admin/js/admin.js (modified) (1 diff)
• bp-templates/bp-legacy/js/buddypress.js (modified) (1 diff)

trunk/bp-loader.php

@@ -304 +304 @@
         /** Versions **************************************************/
 
-        $this->version    = '2.0-alpha-7752';
+        $this->version    = '2.0-alpha-8020';
         $this->db_version = 7892;
 

trunk/bp-members/admin/js/admin.js

@@ -1 @@
-(function( $ ) {
+( function( $ ) {
+    // Profile Visibility Settings
 
-    /** Profile Visibility Settings *********************************/
-    $('.visibility-toggle-link').on( 'click', function( event ) {
-
+    $( '.visibility-toggle-link' ).on( 'click', function( event ) {
         event.preventDefault();
 
-        var toggle_div = $(this).parent();
-
-        $(toggle_div).fadeOut( 600, function(){
-            $(toggle_div).siblings('.field-visibility-settings').slideDown(400);
-        });
-
+        $( this ).parent().hide()
+            .siblings( '.field-visibility-settings' ).show();
     } );
 
-    $('.field-visibility-settings-close').on( 'click', function( event ) {
-
+    $( '.field-visibility-settings-close' ).on( 'click', function( event ) {
         event.preventDefault();
 
-        var settings_div = $(this).parent();
-        var vis_setting_text = settings_div.find('input:checked').parent().text();
+        var settings_div = $(this).parent(),
+        vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
 
-        settings_div.slideUp( 400, function() {
-            settings_div.siblings('.field-visibility-settings-toggle').fadeIn(800);
-            settings_div.siblings('.field-visibility-settings-toggle').children('.current-visibility-level').html(vis_setting_text);
-        } );
-
-        return false;
+        settings_div.hide()
+            .siblings( '.field-visibility-settings-toggle' )
+                .children( '.current-visibility-level' ).text( vis_setting_text ).end()
+            .show();
     } );
 
-})(jQuery);
+} )( jQuery );
 
 

trunk/bp-templates/bp-legacy/js/buddypress.js

@@ -966 +966 @@
 
     /** Profile Visibility Settings *********************************/
-    jq('.field-visibility-settings').hide();
-    jq('.visibility-toggle-link').on( 'click', function() {
-        var toggle_div = jq(this).parent();
-
-        jq(toggle_div).fadeOut( 600, function(){
-            jq(toggle_div).siblings('.field-visibility-settings').slideDown(400);
-        });
-
-        return false;
+    jq( '.visibility-toggle-link' ).on( 'click', function( event ) {
+        event.preventDefault();
+
+        jq( this ).parent().hide()
+            .siblings( '.field-visibility-settings' ).show();
     } );
 
-    jq('.field-visibility-settings-close').on( 'click', function() {
-        var settings_div = jq(this).parent();
-        var vis_setting_text = settings_div.find('input:checked').parent().text();
-
-        settings_div.slideUp( 400, function() {
-            settings_div.siblings('.field-visibility-settings-toggle').fadeIn(800);
-            settings_div.siblings('.field-visibility-settings-toggle').children('.current-visibility-level').html(vis_setting_text);
-        } );
-
-        return false;
+    jq( '.field-visibility-settings-close' ).on( 'click', function( event ) {
+        event.preventDefault();
+
+        var settings_div = jq( this ).parent(),
+            vis_setting_text = settings_div.find( 'input:checked' ).parent().text();
+
+        settings_div.hide()
+            .siblings( '.field-visibility-settings-toggle' )
+                .children( '.current-visibility-level' ).text( vis_setting_text ).end()
+            .show();
     } );