Changeset 8011 for trunk/bp-core/bp-core-cache.php

Timestamp:

03/01/2014 02:30:53 AM (12 years ago)

Author:

boonebgorges

Message:

When updating meta cache for a group of items, make sure empty values are cached

When updating the meta cache for, say, a group of activity items, it's possible
that some activity items won't have any metadata associated with them. In these
cases, we follow WP's update_meta_cache() by caching an empty array for that
item, so as to avoid cache misses.

File:

• trunk/bp-core/bp-core-cache.php (modified) (1 diff)

trunk/bp-core/bp-core-cache.php

@@ -232 +232 @@
         }
 
-        foreach ( $cache as $object_id => $cache_val ) {
-            wp_cache_set( $object_id, $cache_val, $cache_group );
+        foreach ( $uncached_ids as $uncached_id ) {
+            // Cache empty values as well
+            if ( ! isset( $cache[ $uncached_id ] ) ) {
+                $cache[ $uncached_id ] = array();
+            }
+
+            wp_cache_set( $uncached_id, $cache[ $uncached_id ], $cache_group );
         }
     }