Changeset 7994 for trunk/bp-messages/bp-messages-classes.php

Timestamp:

02/26/2014 09:37:39 PM (12 years ago)

Author:

r-a-y

Message:

Add object caching when fetching the active notice.

This commit:

• Introduces a new hook - 'messages_notice_before_delete' to do something before a notice is deleted
• Adds object caching to the BP_Messages_Notice::get_active() method
• Adds a cache invalidation function to bp-messages-cache.php
• Adds a unit test

Fixes #5419

File:

• trunk/bp-messages/bp-messages-classes.php (modified) (2 diffs)

trunk/bp-messages/bp-messages-classes.php

@@ -578 +578 @@
                 global $wpdb, $bp;
 
+                do_action( 'messages_notice_before_delete', $this );
+
                 $sql = $wpdb->prepare( "DELETE FROM {$bp->messages->table_name_notices} WHERE id = %d", $this->id );
 
@@ -644 +646 @@
          */
         public static function get_active() {
-                global $wpdb, $bp;
-
-                $notice_id = $wpdb->get_var( "SELECT id FROM {$bp->messages->table_name_notices} WHERE is_active = 1" );
-
-                return new BP_Messages_Notice( $notice_id );
+                $notice = wp_cache_get( 'active_notice', 'bp_messages' );
+
+                if ( false === $notice ) {
+                        global $wpdb, $bp;
+
+                        $notice_id = $wpdb->get_var( "SELECT id FROM {$bp->messages->table_name_notices} WHERE is_active = 1" );
+                        $notice    = new BP_Messages_Notice( $notice_id );
+
+                        wp_cache_set( 'active_notice', $notice, 'bp_messages' );
+                }
+
+                return $notice;
         }
 }