Changeset 7994

Timestamp:

02/26/2014 09:37:39 PM (11 years ago)

Author:

r-a-y

Message:

Add object caching when fetching the active notice.

This commit:

• Introduces a new hook - 'messages_notice_before_delete' to do something before a notice is deleted
• Adds object caching to the BP_Messages_Notice::get_active() method
• Adds a cache invalidation function to bp-messages-cache.php
• Adds a unit test

Fixes #5419

Location:

trunk

Files:

• bp-messages/bp-messages-cache.php (modified) (1 diff)
• bp-messages/bp-messages-classes.php (modified) (2 diffs)
• tests/testcases/messages (added)
• tests/testcases/messages/class.bp-messages-notice.php (added)

trunk/bp-messages/bp-messages-cache.php

@@ -23 +23 @@
 add_action( 'messages_screen_sentbox', 'bp_core_clear_cache' );
 add_action( 'messages_screen_inbox',   'bp_core_clear_cache' );
+
+/**
+ * Invalidates cache for notices.
+ * 
+ * Currently, invalidates active notice cache.
+ *
+ * @since BuddyPress (2.0.0)
+ */
+function bp_notices_clear_cache( $notice ) {
+    wp_cache_delete( 'active_notice', 'bp_messages' );
+}
+add_action( 'messages_notice_after_save',    'bp_notices_clear_cache' );
+add_action( 'messages_notice_before_delete', 'bp_notices_clear_cache' );

trunk/bp-messages/bp-messages-classes.php

@@ -578 +578 @@
         global $wpdb, $bp;
 
+        do_action( 'messages_notice_before_delete', $this );
+
         $sql = $wpdb->prepare( "DELETE FROM {$bp->messages->table_name_notices} WHERE id = %d", $this->id );
 
@@ -644 +646 @@
      */
     public static function get_active() {
-        global $wpdb, $bp;
-
-        $notice_id = $wpdb->get_var( "SELECT id FROM {$bp->messages->table_name_notices} WHERE is_active = 1" );
-
-        return new BP_Messages_Notice( $notice_id );
+        $notice = wp_cache_get( 'active_notice', 'bp_messages' );
+
+        if ( false === $notice ) {
+            global $wpdb, $bp;
+
+            $notice_id = $wpdb->get_var( "SELECT id FROM {$bp->messages->table_name_notices} WHERE is_active = 1" );
+            $notice    = new BP_Messages_Notice( $notice_id );
+
+            wp_cache_set( 'active_notice', $notice, 'bp_messages' );
+        }
+
+        return $notice;
     }
 }