Changeset 7968 for trunk/bp-messages/bp-messages-classes.php

Timestamp:

02/22/2014 09:40:39 PM (12 years ago)

Author:

r-a-y

Message:

Don't use extract() in BP_Messages_Notice::get_notices().

File:

• trunk/bp-messages/bp-messages-classes.php (modified) (1 diff)

trunk/bp-messages/bp-messages-classes.php

@@ -520 +520 @@
                 global $wpdb, $bp;
 
-                $defaults = array(
+                $r = wp_parse_args( $args, array(
                         'pag_num'  => 20, // Number of notices per page
                         'pag_page' => 1   // Page number
-                );
-                $r = wp_parse_args( $args, $defaults );
-                extract( $r );
+                ) );
 
                 $limit_sql = '';
-                if ( (int) $pag_num >= 0 ) {
-                        $limit_sql = $wpdb->prepare( "LIMIT %d, %d", (int) ( ( $pag_page - 1 ) * $pag_num ), (int) $pag_num );
+                if ( (int) $r['pag_num'] >= 0 ) {
+                        $limit_sql = $wpdb->prepare( "LIMIT %d, %d", (int) ( ( $r['pag_page'] - 1 ) * $r['pag_num'] ), (int) $r['pag_num'] );
                 }