Changeset 7966

Timestamp:

02/22/2014 09:21:21 PM (12 years ago)

Author:

r-a-y

Message:

Don't fetch item counts in profile navigation unnecessarily.

Previously, when a component's setup_nav() method is fired, the item
count for the component is fetched without any conditional checks.

This causes unneccessary queries to be fired when a user isn't logged
in or when we're not on a single user page.

This commit only fetches the item count in the profile nav if we're
currently on a single user page and/or if the current user has access
to the component nav item.

Fixes #5413

Props r-a-y, boonebgorges

Location:

trunk

Files:

• bp-groups/bp-groups-loader.php (modified) (1 diff)
• bp-messages/bp-messages-loader.php (modified) (1 diff)
• bp-notifications/bp-notifications-loader.php (modified) (1 diff)

trunk/bp-groups/bp-groups-loader.php

@@ -347 +347 @@
         public function setup_nav( $main_nav = array(), $sub_nav = array() ) {
 
+                // Only grab count if we're on a user page
+                if ( bp_is_user() ) {
+                        $count    = bp_get_total_group_count_for_user();
+                        $class    = ( 0 === $count ) ? 'no-count' : 'count';
+                        $nav_name = sprintf( __( 'Groups <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) );
+                } else {
+                        $nav_name = __( 'Groups', 'buddypress' );
+                }
+
                 // Add 'Groups' to the main navigation
-                $count    = bp_get_total_group_count_for_user();
-                $class    = ( 0 === $count ) ? 'no-count' : 'count';
                 $main_nav = array(
-                        'name'                => sprintf( __( 'Groups <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) ),
+                        'name'                => $nav_name,
                         'slug'                => $this->slug,
                         'position'            => 70,

trunk/bp-messages/bp-messages-loader.php

@@ -103 +103 @@
         public function setup_nav( $main_nav = array(), $sub_nav = array() ) {
 
+                // Only grab count if we're on a user page and current user has access
+                if ( bp_is_user() && bp_user_has_access() ) {
+                        $count    = bp_get_total_unread_messages_count();
+                        $class    = ( 0 === $count ) ? 'no-count' : 'count';
+                        $nav_name = sprintf( __( 'Messages <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) );
+                } else {
+                        $nav_name = __( 'Messages', 'buddypress' );
+                }
+
                 // Add 'Messages' to the main navigation
-                $count    = bp_get_total_unread_messages_count();
-                $class    = ( 0 === $count ) ? 'no-count' : 'count';
                 $main_nav = array(
-                        'name'                    => sprintf( __( 'Messages <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) ),
+                        'name'                    => $nav_name,
                         'slug'                    => $this->slug,
                         'position'                => 50,

trunk/bp-notifications/bp-notifications-loader.php

@@ -105 +105 @@
         public function setup_nav( $main_nav = array(), $sub_nav = array() ) {
 
+                // Only grab count if we're on a user page and current user has access
+                if ( bp_is_user() && bp_user_has_access() ) {
+                        $count    = bp_notifications_get_unread_notification_count( bp_displayed_user_id() );
+                        $class    = ( 0 === $count ) ? 'no-count' : 'count';
+                        $nav_name = sprintf( __( 'Notifications <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) );
+                } else {
+                        $nav_name = __( 'Notifications', 'buddypress' );
+                }
+
                 // Add 'Notifications' to the main navigation
-                $count    = bp_notifications_get_unread_notification_count( bp_displayed_user_id() );
-                $class    = ( 0 === $count ) ? 'no-count' : 'count';
                 $main_nav = array(
-                        'name'                    => sprintf( __( 'Notifications <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count ) ),
+                        'name'                    => $nav_name,
                         'slug'                    => $this->slug,
                         'position'                => 30,