Changeset 7956 for trunk/bp-groups/bp-groups-functions.php

Timestamp:

02/21/2014 05:51:10 PM (11 years ago)

Author:

boonebgorges

Message:

Overhaul the way that individual group objects are cached

The existing implementation was broken in a number of ways. Most critically,
user-specific data (like is_member) was being stored in the persistent object
cache without respect to user.

This refactor excludes the user-specific data from being cached along with the
group object. It also reworks the way that items are keyed in the cache, for
greater consistency with WordPress and the other BP components.

See #5407

File:

• trunk/bp-groups/bp-groups-functions.php (modified) (1 diff)

trunk/bp-groups/bp-groups-functions.php

@@ -41 +41 @@
  */
 function groups_get_group( $args = '' ) {
-    $defaults = array(
+    $r = wp_parse_args( $args, array(
         'group_id'          => false,
         'load_users'        => false,
         'populate_extras'   => true,
+    ) );
+
+    $group_args = array(
+        'populate_extras' => $r['populate_extras'],
     );
 
-    $args = wp_parse_args( $args, $defaults );
-    extract( $args, EXTR_SKIP );
-
-    $cache_key = 'bp_groups_group_' . $group_id . ( $load_users ? '_load_users' : '_noload_users' );
-
-    if ( !$group = wp_cache_get( $cache_key, 'bp' ) ) {
-        $group_args = array(
-            'populate_extras'   => $populate_extras,
-        );
-
-        $group = new BP_Groups_Group( $group_id, $group_args );
-        wp_cache_set( $cache_key, $group, 'bp' );
-    }
+    $group = new BP_Groups_Group( $r['group_id'], $group_args );
 
     return apply_filters( 'groups_get_group', $group );