Changeset 7946

Timestamp:

02/21/2014 02:37:15 AM (11 years ago)

Author:

r-a-y

Message:

Fix AJAX pagination when clicked page number is 1000 or more.

Previously, BP's javascript was converting the paginated element
content to a number with the Number() function. This doesn't work
with comma-seperated number strings (eg. 1,000), which returned a NaN
value causing problems during the AJAX callback.

This commit changes the way the page number is parsed in BP's
javascript by grabbing the page number from the 'href' attribute.
Thereby, ensuring that AJAX pagination works for pages greater than
1000.

Fixes #5404

File:

• trunk/bp-templates/bp-legacy/js/buddypress.js (modified) (2 diffs)

trunk/bp-templates/bp-legacy/js/buddypress.js

@@ -748 +748 @@
                 var el = jq('li.filter select');
 
-            var page_number = 1;
             var css_id = el.attr('id').split( '-' );
             var object = css_id[0];
@@ -754 +753 @@
             var pagination_id = jq(target).closest('.pagination-links').attr('id');
 
+            var page_number = target.attr('href').split( '=' );
+            page_number = page_number[1];
+
             if ( jq('div.dir-search input').length )
                 search_terms = jq('.dir-search input').val();
 
-            if ( jq(target).hasClass('next') )
-                var page_number = Number( jq('.pagination span.current').html() ) + 1;
-            else if ( jq(target).hasClass('prev') )
-                var page_number = Number( jq('.pagination span.current').html() ) - 1;
-            else
-                var page_number = Number( jq(target).html() );
-            
             if ( pagination_id.indexOf( 'pag-bottom' ) !== -1 ) {
                 var caller = 'pag-bottom';