Changeset 7942

Timestamp:

02/20/2014 09:02:33 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce blog- and group-create button functions, and use to build directory headers in bp-legacy

The new functions bp_get_blog_create_button() and bp_get_group_create_button()
standardize the treatment of these buttons by using bp_get_button(). They also
make life easier for themers, who will not need to build the buttons from
scratch.

In this changeset we modify the way that bp-legacy loads these buttons into the
titles of the directory pages. Previously, it was done directly in BP's theme
compat layer, with the result that all template packs had to follow the
questionable practice of embedding a button inside of a header element. Now,
the directory title is a string, but is filtered; bp-legacy then chooses to
add a button by using the new create-button functions + the new filters.

Fixes #5144

Props hnla, r-a-y

Location:

trunk

Files:

• bp-blogs/bp-blogs-screens.php (modified) (1 diff)
• bp-blogs/bp-blogs-template.php (modified) (1 diff)
• bp-groups/bp-groups-screens.php (modified) (1 diff)
• bp-groups/bp-groups-template.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress-functions.php (modified) (2 diffs)

trunk/bp-blogs/bp-blogs-screens.php

@@ -142 +142 @@
     public function directory_dummy_post() {
 
-        // Title based on ability to create blogs
-        if ( is_user_logged_in() && bp_blog_signup_enabled() ) {
-            $title = __( 'Sites', 'buddypress' ) . '&nbsp;<a class="button" href="' . trailingslashit( bp_get_root_domain() . '/' . bp_get_blogs_root_slug() . '/create' ) . '">' . __( 'Create a Sites', 'buddypress' ) . '</a>';
-        } else {
-            $title = __( 'Sites', 'buddypress' );
-        }
+        $title = apply_filters( 'bp_blogs_directory_title', __( 'Sites', 'buddypress' ) );
 
         bp_theme_compat_reset_post( array(

trunk/bp-blogs/bp-blogs-template.php

@@ -1150 +1150 @@
 
 /**
+ * Output the Create a Site button.
+ *
+ * @since BuddyPress (2.0.0)
+ */
+function bp_blog_create_button() {
+    echo bp_get_blog_create_button();
+}
+    /**
+     * Get the Create a Site button.
+     *
+     * @since BuddyPress (2.0.0)
+     *
+     * @return string
+     */
+    function bp_get_blog_create_button() {
+        if ( ! is_user_logged_in() ) {
+            return false;
+        }
+
+        if ( ! bp_blog_signup_enabled() ) {
+            return false;
+        }
+
+        $button_args = array(
+            'id'         => 'create_blog',
+            'component'  => 'blogs',
+            'link_text'  => __( 'Create a Site', 'buddypress' ),
+            'link_title' => __( 'Create a Site', 'buddypress' ),
+            'link_class' => 'button blog-create bp-title-button',
+            'link_href'  => trailingslashit( bp_get_root_domain() ) . trailingslashit( bp_get_blogs_root_slug() ) . trailingslashit( 'create' ),
+            'wrapper'    => false,
+        );
+
+        return bp_get_button( $button_args );
+    }
+
+/**
  * Output button for visiting a blog in a loop.
  *

trunk/bp-groups/bp-groups-screens.php

@@ -1022 +1022 @@
     public function directory_dummy_post() {
 
-        // Title based on ability to create groups
-        if ( is_user_logged_in() && bp_user_can_create_groups() ) {
-            $title = __( 'Groups', 'buddypress' ) . '&nbsp;<a class="button bp-title-button" href="' . trailingslashit( bp_get_root_domain() . '/' . bp_get_groups_root_slug() . '/create' ) . '">' . __( 'Create a Group', 'buddypress' ) . '</a>';
-        } else {
-            $title = __( 'Groups', 'buddypress' );
-        }
+        $title = apply_filters( 'bp_groups_directory_title', __( 'Groups', 'buddypress' ) );
 
         bp_theme_compat_reset_post( array(

trunk/bp-groups/bp-groups-template.php

@@ -1855 +1855 @@
 
 /**
+ * Output the Create a Group button.
+ *
+ * @since BuddyPress (2.0.0)
+ */
+function bp_group_create_button() {
+    echo bp_get_group_create_button();
+}
+    /**
+     * Get the Create a Group button.
+     *
+     * @since BuddyPress (2.0.0)
+     *
+     * @return string
+     */
+    function bp_get_group_create_button() {
+        if ( ! is_user_logged_in() ) {
+            return false;
+        }
+
+        if ( ! bp_user_can_create_groups() ) {
+            return false;
+        }
+
+        $button_args = array(
+            'id'         => 'create_group',
+            'component'  => 'groups',
+            'link_text'  => __( 'Create a Group', 'buddypress' ),
+            'link_title' => __( 'Create a Group', 'buddypress' ),
+            'link_class' => 'button group-create bp-title-button',
+            'link_href'  => trailingslashit( bp_get_root_domain() ) . trailingslashit( bp_get_groups_root_slug() ) . trailingslashit( 'create' ),
+            'wrapper'    => false,
+        );
+
+        return bp_get_button( $button_args );
+    }
+
+/**
  * Prints a message if the group is not visible to the current user (it is a
  * hidden or private group, and the user does not have access).

trunk/bp-templates/bp-legacy/buddypress-functions.php

@@ -112 +112 @@
                 add_action( 'bp_group_header_actions',     'bp_group_new_topic_button',      20 );
                 add_action( 'bp_directory_groups_actions', 'bp_group_join_button' );
+                add_filter( 'bp_groups_directory_title',   'bp_legacy_theme_group_create_button' );
+                add_filter( 'bp_blogs_directory_title',    'bp_legacy_theme_blog_create_button' );
             }
 
@@ -421 +423 @@
 
 /**
+ * Add the Create a Group button to the Groups directory title.
+ *
+ * bp-legacy puts the Create a Group button into the page title, to mimic
+ * the behavior of bp-default.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param string $title Groups directory title.
+ * @return string
+ */
+function bp_legacy_theme_group_create_button( $title ) {
+    return $title . ' ' . bp_get_group_create_button();
+}
+
+/**
+ * Add the Create a Site button to the Sites directory title.
+ *
+ * bp-legacy puts the Create a Site button into the page title, to mimic
+ * the behavior of bp-default.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param string $title Sites directory title.
+ * @return string
+ */
+function bp_legacy_theme_blog_create_button( $title ) {
+    return $title . ' ' . bp_get_blog_create_button();
+}
+/**
  * This function looks scarier than it actually is. :)
  * Each object loop (activity/members/groups/blogs/forums) contains default