Changeset 7918 for trunk/bp-blogs/bp-blogs-template.php

Timestamp:

02/18/2014 12:50:11 PM (11 years ago)

Author:

boonebgorges

Message:

Pre-fetch blogmeta when in blog loops

This reduces overhead when querying for blog meta in the context of a
bp_has_blogs() template loop. Mirrors similar functionality in the activity,
groups, and xprofile components.

Also introduces an update_meta_cache parameter to the bp_has_blogs() stack, so
that plugin/theme authors can disable this pre-fetching.

Fixes #5398

File:

• trunk/bp-blogs/bp-blogs-template.php (modified) (4 diffs)

trunk/bp-blogs/bp-blogs-template.php

@@ -170 +170 @@
      * @param string $page_arg The string used as a query parameter in
      *        pagination links. Default: 'bpage'.
-     */
-    function __construct( $type, $page, $per_page, $max, $user_id, $search_terms, $page_arg = 'bpage' ) {
+     * @param bool $update_meta_cache Whether to pre-fetch metadata for
+     *        queried blogs.
+     */
+    function __construct( $type, $page, $per_page, $max, $user_id, $search_terms, $page_arg = 'bpage', $update_meta_cache = true ) {
 
         $this->pag_page = isset( $_REQUEST[$page_arg] ) ? intval( $_REQUEST[$page_arg] ) : $page;
@@ -179 +181 @@
             $this->blogs = BP_Blogs_Blog::get_by_letter( $_REQUEST['letter'], $this->pag_num, $this->pag_page );
         else
-            $this->blogs = bp_blogs_get_blogs( array( 'type' => $type, 'per_page' => $this->pag_num, 'page' => $this->pag_page, 'user_id' => $user_id, 'search_terms' => $search_terms ) );
+            $this->blogs = bp_blogs_get_blogs( array( 'type' => $type, 'per_page' => $this->pag_num, 'page' => $this->pag_page, 'user_id' => $user_id, 'search_terms' => $search_terms, 'update_meta_cache' => $update_meta_cache, ) );
 
         if ( !$max || $max >= (int) $this->blogs['total'] )
@@ -360 +362 @@
 
         'user_id'      => $user_id,       // Pass a user_id to limit to only blogs this user has higher than subscriber access to
-        'search_terms' => $search_terms   // Pass search terms to filter on the blog title or description.
+        'search_terms' => $search_terms,  // Pass search terms to filter on the blog title or description.
+        'update_meta_cache' => true,
     );
 
@@ -379 +382 @@
     }
 
-    $blogs_template = new BP_Blogs_Template( $type, $page, $per_page, $max, $user_id, $search_terms, $page_arg );
+    $blogs_template = new BP_Blogs_Template( $type, $page, $per_page, $max, $user_id, $search_terms, $page_arg, $update_meta_cache );
     return apply_filters( 'bp_has_blogs', $blogs_template->has_blogs(), $blogs_template );
 }