Changeset 7903 for trunk/tests/testcases/groups/functions.php

Timestamp:

02/17/2014 12:35:26 AM (13 years ago)

Author:

boonebgorges

Message:

Don't prime groupmeta cache in BP_Groups_Group::construct()

groups_get_groupmeta() now uses the core API functions. get_metadata() works by
priming the cache with *all* object metadata when requesting any piece of
metadata for that object. This means that, instead of pre-fetching groupmeta
when instantiating BP_Groups_Group, we wait until it happens in get_metadata().
At best, this can help us to avoid pre-fetching a meta cache that will not be
used.

See #5398

File:

• trunk/tests/testcases/groups/functions.php (modified) (1 diff)

trunk/tests/testcases/groups/functions.php

@@ -438 +438 @@
         /**
          * @group groupmeta
+         * @group groups_get_groupmeta
+         * @group cache
+         */
+        public function test_groups_get_groupmeta_cache_all_on_get() {
+                $g = $this->factory->group->create();
+                groups_add_groupmeta( $g, 'foo', 'bar' );
+                groups_add_groupmeta( $g, 'foo1', 'baz' );
+                $this->assertFalse( wp_cache_get( $g, 'group_meta' ) );
+
+                // A single query should prime the whole meta cache
+                groups_get_groupmeta( $g, 'foo' );
+
+                $c = wp_cache_get( $g, 'group_meta' );
+                $this->assertNotEmpty( $c['foo1'] );
+        }
+
+        /**
+         * @group groupmeta
          */
         public function test_groups_delete_groupmeta_non_numeric_id() {