Changeset 7901

Timestamp:

02/16/2014 11:51:32 PM (11 years ago)

Author:

boonebgorges

Message:

Don't prime activitymeta cache in BP_Activity_Activity::construct()

bp_activity_get_meta() now uses the core API functions. get_metadata() works by
priming the cache with *all* object metadata when requesting any piece of
metadata for that object. This means that, instead of pre-fetching activitymeta
when instantiating BP_Activity_Activity, we wait until it happens in
get_metadata(). At best, this can help us to avoid pre-fetching a meta cache
that will not be used.

See #5398

Location:

trunk

Files:

• bp-activity/bp-activity-classes.php (modified) (1 diff)
• tests/testcases/activity/functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-classes.php

@@ -159 +159 @@
             $this->mptt_right        = $row->mptt_right;
             $this->is_spam           = $row->is_spam;
-
-            bp_activity_update_meta_cache( $this->id );
         }
     }

trunk/tests/testcases/activity/functions.php

@@ -298 +298 @@
         bp_activity_add_meta( $a, 'foo', 'baz' );
         $this->assertSame( array( 'bar', 'baz' ), bp_activity_get_meta( $a, 'foo', false ) );
+    }
+
+    /**
+     * @group activitymeta
+     * @group bp_activity_get_meta
+     * @group cache
+     */
+    public function test_bp_activity_get_meta_cache_all_on_get() {
+        $a = $this->factory->activity->create();
+        bp_activity_add_meta( $a, 'foo', 'bar' );
+        bp_activity_add_meta( $a, 'foo1', 'baz' );
+        $this->assertFalse( wp_cache_get( $a, 'activity_meta' ) );
+
+        // A single query should prime the whole meta cache
+        bp_activity_get_meta( $a, 'foo' );
+
+        $c = wp_cache_get( $a, 'activity_meta' );
+        $this->assertNotEmpty( $c['foo1'] );
     }