Changeset 7890

Timestamp:

02/16/2014 03:58:37 PM (13 years ago)

Author:

boonebgorges

Message:

Don't auto-link @mentions that appear inside the context of links

This prevents illegitimate double-linking when text like
href="mailto:foo@…" or <a href="​http://twitter.com/bar">@bar</a> happen
to match a BP username like @bar.

Fixes #4680

Props ninnypants

Location:

trunk

Files:

• bp-activity/bp-activity-filters.php (modified) (2 diffs)
• tests/testcases/activity/filters.php (added)

trunk/bp-activity/bp-activity-filters.php

@@ -196 +196 @@
 
 /**
- * Finds and links @-mentioned users in the contents of a given item.
- *
- * @since BuddyPress (1.2)
- *
- * @uses bp_activity_find_mentions()
- * @uses bp_core_get_user_domain()
+ * Find and link @-mentioned users in the contents of a given item.
+ *
+ * @since BuddyPress (1.2.0)
  *
  * @param string $content The contents of a given item.
@@ -221 +218 @@
                 return $content;
 
+        // We don't want to link @mentions that are inside of links, so we
+        // temporarily remove them
+        $replace_count = 0;
+        $replacements = array();
+        foreach ( $usernames as $username ) {
+                // prevent @ name linking inside <a> tags
+                preg_match_all( '/(<a.*?(?!<\/a>)@' . $username . '.*?<\/a>)/', $content, $content_matches );
+                if ( ! empty( $content_matches[1] ) ) {
+                        foreach ( $content_matches[1] as $replacement ) {
+                                $replacements[ '#BPAN' . $replace_count ] = $replacement;
+                                $content = str_replace( $replacement, '#BPAN' . $replace_count, $content );
+                                $replace_count++;
+                        }
+                }
+        }
+
         // Linkify the mentions with the username
-        foreach( (array) $usernames as $user_id => $username ) {
+        foreach ( (array) $usernames as $user_id => $username ) {
                 $content = preg_replace( '/(@' . $username . '\b)/', "<a href='" . bp_core_get_user_domain( $user_id ) . "' rel='nofollow'>@$username</a>", $content );
+        }
+
+        // put everything back
+        if ( ! empty( $replacements ) ) {
+                foreach ( $replacements as $placeholder => $original ) {
+                        $content = str_replace( $placeholder, $original, $content );
+                }
         }