Changeset 7887 for trunk/tests/testcases/groups/functions.php

Timestamp:

02/14/2014 07:51:11 PM (11 years ago)

Author:

boonebgorges

Message:

Don't test prev_value return value on WP < 3.7

There was a bug prior to WP 3.7 that caused update_metadata() to return true
even when the update failed due to a 'prev_value' parameter not being matched.
Since this is not really a functionality issue, but is more about error
reporting, it doesn't affect end-user functionality in BP, except insofar as
the function will return an unexpected value in those cases. Instead of coming
up with an arcane workaround for these old versions, we'll just skip the tests
for the time being.

See ​https://core.trac.wordpress.org/ticket/24933 for background on the WP issue

File:

• trunk/tests/testcases/groups/functions.php (modified) (1 diff)

trunk/tests/testcases/groups/functions.php

@@ -342 +342 @@
         $g = $this->factory->group->create();
         groups_add_groupmeta( $g, 'foo', 'bar' );
-        $this->assertFalse( groups_update_groupmeta( $g, 'foo', 'bar2', 'baz' ) );
+
+        // In earlier versions of WordPress, bp_activity_update_meta()
+        // returns true even on failure. However, we know that in these
+        // cases the update is failing as expected, so we skip this
+        // assertion just to keep our tests passing
+        // See https://core.trac.wordpress.org/ticket/24933
+        if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
+            $this->assertFalse( groups_update_groupmeta( $g, 'foo', 'bar2', 'baz' ) );
+        }
+
         $this->assertTrue( groups_update_groupmeta( $g, 'foo', 'bar2', 'bar' ) );
     }