Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
02/14/2014 07:51:11 PM (8 years ago)
Author:
boonebgorges
Message:

Don't test prev_value return value on WP < 3.7

There was a bug prior to WP 3.7 that caused update_metadata() to return true
even when the update failed due to a 'prev_value' parameter not being matched.
Since this is not really a functionality issue, but is more about error
reporting, it doesn't affect end-user functionality in BP, except insofar as
the function will return an unexpected value in those cases. Instead of coming
up with an arcane workaround for these old versions, we'll just skip the tests
for the time being.

See https://core.trac.wordpress.org/ticket/24933 for background on the WP issue

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/testcases/activity/functions.php

    r7885 r7887  
    199199        $a = $this->factory->activity->create();
    200200        bp_activity_add_meta( $a, 'foo', 'bar' );
    201         $this->assertFalse( bp_activity_update_meta( $a, 'foo', 'bar2', 'baz' ) );
     201
     202        // In earlier versions of WordPress, bp_activity_update_meta()
     203        // returns true even on failure. However, we know that in these
     204        // cases the update is failing as expected, so we skip this
     205        // assertion just to keep our tests passing
     206        // See https://core.trac.wordpress.org/ticket/24933
     207        if ( version_compare( $GLOBALS['wp_version'], '3.7', '>=' ) ) {
     208            $this->assertFalse( bp_activity_update_meta( $a, 'foo', 'bar2', 'baz' ) );
     209        }
     210
    202211        $this->assertTrue( bp_activity_update_meta( $a, 'foo', 'bar2', 'bar' ) );
    203212    }
Note: See TracChangeset for help on using the changeset viewer.