Changeset 7883 for trunk/tests/testcases/groups/functions.php

Timestamp:

02/14/2014 07:02:16 PM (11 years ago)

Author:

boonebgorges

Message:

Add delete_all support for all _delete_meta() functions

The delete_all parameter allows you to delete all meta items matching the
specified meta_key, regardless of the associated object.

Because our meta delete functions also support the deletion of all metadata
associated with an object (by leaving out the meta_key param), a decision had
to be made regarding the behavior when _delete_meta() is called with delete_all

true and meta_key = false. The most logical (and least destructive) strategy

was deemed to be: force delete_all to false when meta_key is also false. This
ensures that you don't accidentally wipe out all metadata for a component.

See #5400

File:

• trunk/tests/testcases/groups/functions.php (modified) (1 diff)

trunk/tests/testcases/groups/functions.php

@@ -437 +437 @@
     /**
      * @group groupmeta
+     * @group groups_delete_groupmeta
+     */
+    public function test_groups_delete_groupmeta_with_delete_all_but_no_meta_key() {
+        // With no meta key, don't delete for all items - just delete
+        // all for a single item
+        $g1 = $this->factory->group->create();
+        $g2 = $this->factory->group->create();
+        groups_add_groupmeta( $g1, 'foo', 'bar' );
+        groups_add_groupmeta( $g1, 'foo1', 'bar1' );
+        groups_add_groupmeta( $g2, 'foo', 'bar' );
+        groups_add_groupmeta( $g2, 'foo1', 'bar1' );
+
+        $this->assertTrue( groups_delete_groupmeta( $g1, '', '', true ) );
+        $this->assertEmpty( groups_get_groupmeta( $g1 ) );
+        $this->assertSame( 'bar', groups_get_groupmeta( $g2, 'foo' ) );
+        $this->assertSame( 'bar1', groups_get_groupmeta( $g2, 'foo1' ) );
+    }
+
+    /**
+     * @group groupmeta
+     * @group groups_delete_groupmeta
+     */
+    public function test_groups_delete_groupmeta_with_delete_all() {
+        // With no meta key, don't delete for all items - just delete
+        // all for a single item
+        $g1 = $this->factory->group->create();
+        $g2 = $this->factory->group->create();
+        groups_add_groupmeta( $g1, 'foo', 'bar' );
+        groups_add_groupmeta( $g1, 'foo1', 'bar1' );
+        groups_add_groupmeta( $g2, 'foo', 'bar' );
+        groups_add_groupmeta( $g2, 'foo1', 'bar1' );
+
+        $this->assertTrue( groups_delete_groupmeta( $g1, 'foo', '', true ) );
+        $this->assertEmpty( '', groups_get_groupmeta( $g1, 'foo' ) );
+        $this->assertEmpty( '', groups_get_groupmeta( $g2, 'foo' ) );
+        $this->assertSame( 'bar1', groups_get_groupmeta( $g1, 'foo1' ) );
+        $this->assertSame( 'bar1', groups_get_groupmeta( $g2, 'foo1' ) );
+    }
+
+    /**
+     * @group groupmeta
      * @group groups_add_groupmeta
      */