Changeset 7883 for trunk/bp-groups/bp-groups-functions.php

Timestamp:

02/14/2014 07:02:16 PM (10 years ago)

Author:

boonebgorges

Message:

Add delete_all support for all _delete_meta() functions

The delete_all parameter allows you to delete all meta items matching the
specified meta_key, regardless of the associated object.

Because our meta delete functions also support the deletion of all metadata
associated with an object (by leaving out the meta_key param), a decision had
to be made regarding the behavior when _delete_meta() is called with delete_all

true and meta_key = false. The most logical (and least destructive) strategy

was deemed to be: force delete_all to false when meta_key is also false. This
ensures that you don't accidentally wipe out all metadata for a component.

See #5400

File:

• trunk/bp-groups/bp-groups-functions.php (modified) (2 diffs)

trunk/bp-groups/bp-groups-functions.php

@@ -966 +966 @@
  * @param bool $delete_all Optional. If true, delete matching metadata entries
  *        for all groups. Default: false.
+ * @param bool $delete_all Optional. If true, delete matching metadata entries
+ *    for all objects, ignoring the specified group_id. Otherwise, only
+ *    delete matching metadata entries for the specified group.
+ *    Default: false.
  * @return bool True on success, false on failure.
  */
 function groups_delete_groupmeta( $group_id, $meta_key = false, $meta_value = false, $delete_all = false ) {
+    global $wpdb;
 
     // Legacy - return false if non-int group ID
@@ -978 +983 @@
     $meta_key = preg_replace( '|[^a-z0-9_]|i', '', $meta_key );
 
+    // Legacy - if no meta_key is passed, delete all for the item
+    if ( empty( $meta_key ) ) {
+        $keys = $wpdb->get_col( $wpdb->prepare( "SELECT meta_key FROM {$wpdb->groupmeta} WHERE group_id = %d", $group_id ) );
+
+        // With no meta_key, ignore $delete_all
+        $delete_all = false;
+    } else {
+        $keys = array( $meta_key );
+    }
+
     add_filter( 'query', 'bp_filter_metaid_column_name' );
-    $retval = delete_metadata( 'group', $group_id, $meta_key, $meta_value, $delete_all );
+
+    foreach ( $keys as $key ) {
+        $retval = delete_metadata( 'group', $group_id, $key, $meta_value, $delete_all );
+    }
+
     remove_filter( 'query', 'bp_filter_metaid_column_name' );